Fix configuration of the unsaved tab dirty indicator#4133
Merged
iloveeclipse merged 1 commit intoJun 22, 2026
Merged
Conversation
The dirty indicator preference was only shown and stored while CSS theming was active, so it could not be turned off when started with -cssTheme none or in high-contrast mode. It is now created, stored and reset next to the "Show most recently used tabs" option and is therefore always available. The renderer also read the value from the instance scope only, which ignored a default contributed through product customization (SHOW_DIRTY_INDICATOR_ON_TABS in plugin_customization.ini). It now reads via the preferences service so the default scope is honored. Fixes eclipse-platform#4130
| return preferences.getBoolean(CTabRendering.SHOW_DIRTY_INDICATOR_ON_TABS, | ||
| CTabRendering.SHOW_DIRTY_INDICATOR_ON_TABS_DEFAULT); | ||
| // Use the preferences service so product customization (default scope) is honored | ||
| return Platform.getPreferencesService().getBoolean( |
Member
There was a problem hiding this comment.
Note, 5 lines above there is yet another wrong access to preferences to read the MRU value.
Contributor
Author
There was a problem hiding this comment.
Agree, but unrelated to this change, please fix via separate PR, I don't want to mix unrelated things in this change.
Contributor
Contributor
Author
|
Also ready from my side, feel free to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dirty indicator preference was only shown and stored while CSS theming was active, so it could not be turned off when Eclipse was started with
-cssTheme noneor in high-contrast mode. It is now created, stored and reset next to the "Show most recently used tabs" option and is therefore always available.The renderer also read the value from the instance scope only, which ignored a default contributed through product customization (
SHOW_DIRTY_INDICATOR_ON_TABSinplugin_customization.ini). It now reads via the preferences service so the default scope is honored, allowing products to restore the old asterisk behavior.Fixes #4130