Stabilize QuickAccessDialogTest UI-responsiveness check#4128
Merged
vogella merged 1 commit intoJun 22, 2026
Merged
Conversation
Contributor
testLongRunningComputerDoesntFreezeUI measured UI blocking via the DisplayHelper.waitForCondition tick, whose loop parks in Display.sleep() when idle. While the second dialog restored a previous pick on the worker thread the UI thread was idle, not frozen, but the idle interval was counted as a block and intermittently exceeded the 3s threshold on macOS. Probe responsiveness with a self-rescheduling Display.timerExec instead: the timer keeps firing while the UI thread can dispatch events, so idle waiting registers as short gaps while a genuine freeze still produces a large one.
vogella
force-pushed
the
lv/stabilize-quickaccess-freeze-test
branch
from
558ec00 to
0439a3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testLongRunningComputerDoesntFreezeUI measured UI blocking through the DisplayHelper.waitForCondition tick, whose loop parks in Display.sleep() while idle. When the second dialog restored a previous pick on the worker thread the UI thread was idle rather than frozen, but that idle interval was counted as a block and intermittently crossed the 3s threshold on macOS, so the test failed without any real UI freeze.
This switches the measurement to a self-rescheduling Display.timerExec probe. The timer keeps firing as long as the UI thread can dispatch events, so idle waiting now registers as short gaps while a genuine freeze still produces a large gap and fails the assertion. Test-only change.