test(intent): guard personal (my) pages call App.services.api (regression #6263)#6269
Merged
Merged
Conversation
…sion #6263) IntentEmissionCoverageIT already covers the personal (my) surface on the backend (scoped controller, forced owner FK, sensitive scrub) and asserts the my list page references its scoped controller - but that string is present regardless of the API object, so #6263 (pages calling the nonexistent App.api instead of App.services.api) shipped with every pipeline step green and only surfaced by driving the My shell. Assert the API object itself on the personal list, form and child-form pages: they must call App.services.api and must not contain App.api. - closing the silent-degradation gap for this class. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IntentEmissionCoverageIT covers the personal (my) surface on the backend (scoped controller, forced owner FK, sensitive scrub) and checks that the my list page references its scoped controller. But that string (
ClaimMyController) is present regardless of which API object the page calls, so #6263 - personal pages calling the nonexistentApp.apiinstead ofApp.services.api- shipped with every pipeline step green and only surfaced by driving the My shell at runtime (Cannot read properties of undefined (reading 'get')on every personal list/form load, save, delete).This adds the missing assertion at the emitted-page layer: the personal list, form, and child-form pages must call
App.services.apiand must not containApp.api.. Closes the silent-degradation gap for this class (the same spirit as the rest of this IT - assert the outermost observable layer, not just the parsed model or an incidental substring).No behavior change - assertions only; green on current master (the fix merged in #6263).
🤖 Generated with Claude Code