fix(my-shell): close the sidebar-content div so the split lays out#6265
Merged
Conversation
…idebar was floating over content) The My Shell index.html (resources-my, from the personalization shell #6260) never closed its <div x-h-sidebar-content>. With that one </div> missing, the whole tag nesting shifted by one: the footer's closes were consumed by sidebar-content and sidebar, so the sidebar's <div x-h-split-panel> was never closed and the MAIN panel nested inside it. The x-h-split then had a single child, collapsing the two-column layout - the sidebar rendered as a floating overlay at the left, partially hiding the main content. Add the missing </div> after the domain-apps </template> (matching the shared application shell). The document is now div-balanced (48/48). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The main-panel toolbar reused the application shell's 'Applications' title; in the personal My Shell it should read 'My Applications'. New i18n key application-core:shell.nav.myApplications with that fallback. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the My Shell (
/services/web/my/), the sidebar does not dock at the left — it renders as a floating overlay on top of the main content, which sits at the far left partially hidden behind it.Cause
resources-my/…/my/index.html(from the personalization My Shell, #6260) never closes its<div x-h-sidebar-content>. With that one</div>missing, the tag nesting shifts by one from the domain-apps</template>onward: the footer's closing divs are consumed byx-h-sidebar-contentandx-h-sidebar, so the sidebar's<div x-h-split-panel>is never closed and the main panel nests inside the sidebar panel. Thex-h-splitis then left with a single child, collapsing the two-column layout.The shared application shell (
resources-application) has the correct structure — it closesx-h-sidebar-contentright after its groups, before the footer.Fix
Add the missing
</div>after the domain-apps</template>(one line). The document is now<div>/</div>balanced (48/48), matching the application shell, so the sidebar and main panels are proper siblings ofx-h-split.Pre-existing bug in the My Shell; unrelated to the icon / personal-page API fixes in the sibling PRs.
🤖 Generated with Claude Code