feat(ui): list the Application and My shells in the IDE Window -> Shells menu#6262
Merged
Conversation
…lls menu The Window -> Shells submenu is fed by the 'platform-shells' extension point, but only shell-ide (Workbench) and the Dashboard registered a shell extension - the shared application shell (/services/web/application/) and the new personal My Shell (/services/web/my/) were not reachable from the IDE menu. Register both via the same extension + config pattern as the Dashboard: - resources-application: applicationShell 'Applications' -> /services/web/application/index.html - resources-my: myShell 'My' -> /services/web/my/index.html Verified on a fresh fat-jar boot: the menus extension service returns both entries under Window -> Shells (Applications, Dashboard, My, Workbench) and both linked pages serve 200. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Web IDE's Window -> Shells submenu is populated from the
platform-shellsextension point, but only the Workbench (shell-ide) and the Dashboard contributed a shell extension. The shared application shell (/services/web/application/) and the new personal My Shell (/services/web/my/, #6260) were not reachable from the menu.This registers both, mirroring the Dashboard's extension + config pattern:
resources-application:applicationShell— Applications ->/services/web/application/index.htmlresources-my:myShell— My ->/services/web/my/index.htmlVerified
On a freshly packaged fat jar, the menus extension service (
/services/js/platform-core/extension-services/menus.js) returns Window -> Shells with all four entries — Applications, Dashboard, My, Workbench — and both linked pages serve 200.🤖 Generated with Claude Code