fix(harmonia): calendar/slots entities missing from the shared application shell navigation#6259
Merged
Merged
Conversation
Add the 'console' view to the Git perspective's bottom pane, ordered before History so it is the first and initially focused tab. Cloning a project with many git dependencies previously showed no feedback until completion; the Console streams the clone/publish log messages so the progress is visible as each project lands. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…pplication shell A PRIMARY entity rendered as a calendar (view: calendar / range -> MANAGE_CALENDAR) or a slot picker (view: slots -> MANAGE_SLOTS) generated its page and routes in the project's own SPA but was missing from navigation.js's PERSPECTIVE_COLLECTIONS, so it never registered an application-perspectives extension - the entity was unreachable from the shared application shell (no sidebar entry in any navigation group or projection). Add uiCalendarModels and uiSlotsModels to the perspective collections; the generic perspective template already fits (the SPA routes #/<Entity> to the calendar/slots page). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PRIMARY entity with
view: calendar,view: range, orview: slots(layoutMANAGE_CALENDAR/MANAGE_SLOTS) generates its page and routes inside the project's own Harmonia SPA, butnavigation.jsdid not includeuiCalendarModels/uiSlotsModelsinPERSPECTIVE_COLLECTIONS— so such an entity never contributed anapplication-perspectivesextension and was unreachable from the shared application shell: no sidebar entry in any navigation group, hence absent from every projection.Observed on generated apps: a vacation-request range calendar and an appointment slot picker were invisible in the shell while their list/manage/document siblings all appeared.
Fix: add the two collections to
PERSPECTIVE_COLLECTIONS. The genericperspective.js.templateneeds no changes — the generated SPA already routes#/<Entity>to the calendar/slots page, which is exactly the path shape the perspective emits.Verified by regenerating both affected apps:
gen/<folder>/perspectives/<Entity>/perspective.{js,extension}are emitted and the shell lists the entries under their intentgroup:.🤖 Generated with Claude Code