Fix BlkReadTracker firing waiter callback under hashmap write lock. - #899
Open
Besroy wants to merge 1 commit into
Open
Fix BlkReadTracker firing waiter callback under hashmap write lock.#899Besroy wants to merge 1 commit into
Besroy wants to merge 1 commit into
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stable/v7.x #899 +/- ##
==============================================
Coverage ? 48.32%
==============================================
Files ? 110
Lines ? 13119
Branches ? 6325
==============================================
Hits ? 6340
Misses ? 2548
Partials ? 4231 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
JacksonYao287
previously approved these changes
Jul 19, 2026
JacksonYao287
left a comment
JacksonYao287
left a comment
Member
There was a problem hiding this comment.
Root cause analysis LGTM. Moving m_waiters out before delete n ensures ~blk_track_waiter / m_cb() runs after the bucket unique_lock is released。
Move waiters out of the record before delete so m_cb() runs after the lock is released, avoiding deadlock when the callback requires other resources. Add a regression test to verify the fix.
Besroy
force-pushed
the
fix_blk_read_tracker
branch
from
August 17, 2026 06:30
56d72a4 to
d6ab2c1
Compare
Contributor
Author
|
This PR uses folly::xxx; let's put it on hold for now and decide whether to merge it after the folly migration done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move waiters out of the record before delete so m_cb() runs after the lock is released, avoiding deadlock when the callback requires other resources. Add a regression test to verify the fix.