Hide archived in assignment view - #2735
Open
ZoqkMaze wants to merge 6 commits into
Open
Conversation
richardebeling
approved these changes
Jun 1, 2026
niklasmohrin
reviewed
Jun 8, 2026
niklasmohrin
left a comment
niklasmohrin
left a comment
Member
There was a problem hiding this comment.
Test please? (there should be an existing one which only needs a small addition) :)
janno42
approved these changes
Jun 16, 2026
janno42
approved these changes
Aug 3, 2026
Member
|
@richardebeling hm, latest commit failed once on evap.staff.tests.test_live.QuestionnaireEditLiveTest.test_question_ordering : https://github.com/e-valuation/EvaP/actions/runs/30842097834/job/91781380948 (re-run made it succeed) kind of a weird test to turn flaky 🤔 |
niklasmohrin
reviewed
Aug 3, 2026
| @@ -526,7 +526,7 @@ def test_there_can_be_no_contributions(self): | |||
|
|
|||
| def test_hidden_and_managers_only(self): | |||
Member
There was a problem hiding this comment.
test name should be updated
| @@ -556,14 +559,14 @@ def test_hidden_and_managers_only(self): | |||
| self.assertEqual(expected, set(formset.forms[1].fields["questionnaires"].queryset)) | |||
|
|
|||
| # Suppose we had a hidden questionnaire already selected, that should be shown as well. | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2731