Reject quadratic biases for unknown edges - #82
Open
danielgaskins wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at #19, I noticed that
set_quadraticleaves the edge index asNonewhen neither orientation exists in the model. PyTorch treatsparameter[None]as an extra dimension, so assigning the requested bias broadcasts it across every quadratic weight instead of rejecting the input.Raise a
ValueErrorbefore the assignment. The existing test happened to use a nonexistent edge and only checked the first overwritten bias, so update it to use an actual reversed edge and add a regression test confirming that an unknown edge leaves every bias unchanged.Tests:
python3 -m unittest discover -s tests -vreno lintpython3 -m compileall -q dwave tests