Add an option to disable CA certificate pinning#310
Merged
Conversation
AaronAtDuo
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
disable_ca_pinning=Falseparameter toClient.__init__()ValueErrorif bothdisable_ca_pinning=Trueand a customca_certspath are provided_connect()that, whendisable_ca_pinningis enabled, creates anhttp.client.HTTPSConnectionwithssl.create_default_context()instead of usingCertValidatingHTTPSConnectionwith the bundled CA bundle--disable-ca-pinningargument to the CLImain()entry pointHow Has This Been Tested?
TestDisableCaPinningInit— 7 tests verifying constructor behavior:Falseand uses bundled CA certsTruewith default orNoneca_certsValueErrorwhen combined with a customca_certspathValueErrorwhen combined withca_certs='HTTP'ValueErrorwhen combined withca_certs='DISABLE'TestDisableCaPinningConnect— 5 tests verifying connection behavior:CertValidatingHTTPSConnection(pinned)http.client.HTTPSConnection(not pinned)ssl.CERT_REQUIREDandcheck_hostname=Truessl.create_default_context()settingsCERT_REQUIREDon its custom SSL contextTypes of Changes