Skip to content

Replace lsblk fs detection with blkid#3979

Merged
r4victor merged 2 commits into
masterfrom
issue_3973_volume_fs_detection
Jun 18, 2026
Merged

Replace lsblk fs detection with blkid#3979
r4victor merged 2 commits into
masterfrom
issue_3973_volume_fs_detection

Conversation

@r4victor

@r4victor r4victor commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Harden shim's no filesystem detection on dstack-managed volumes:

  • Replace lsblk -no FSTYPE that reads from the udev cache with blkid -p superblock that reads device superblock directly.
  • Add a readiness gate (waitForBlockDevice + blockDeviceSize): before any format decision the device must be a real block device with non-zero size (syscall via unix.IoctlGetInt, BLKGETSIZE64).
  • Introduce 3 extra blkid probes that re-confirm a "no filesystem" verdict with 1s intervals. This is to protect from a hypothetical attach-flakiness.

@r4victor r4victor merged commit 9c1e460 into master Jun 18, 2026
42 of 48 checks passed
@r4victor r4victor deleted the issue_3973_volume_fs_detection branch June 18, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant