Dadofixes - #1
Open
zoharbenaharon wants to merge 13 commits into
Open
Conversation
zoharbenaharon
commented
Nov 7, 2016
Author
There was a problem hiding this comment.
need to Surround in line 392 the
int use_cuda
with
]#ifdef HAVE_CUDA
Owner
There was a problem hiding this comment.
I don't need this change except for system testing. So unless you deem it interesting for general use, feel free to drop it.
Author
There was a problem hiding this comment.
Could you drop commit 1db9f45f6d10faad47153c1652543ae5009f2425 and add the above ffix at line 392 , then i can merge it into petftest
zoharbenaharon
commented
Nov 7, 2016
zoharbenaharon
left a comment
zoharbenaharon
left a comment
Author
There was a problem hiding this comment.
case the required commit is the HAVE CUDA only , add the surrounding in perftest_parameters.h:392 as mentioned.
case you wish to add the keystroke as well please add as separate commit
Owner
|
@zoharbmellanox, please review |
Enable send and read latency benchmarks with CUDA. write_lat does not work and is not correctly handled yet.
add error checking for cuMemFree
drossetti
pushed a commit
that referenced
this pull request
Jul 16, 2020
merge from linux-rdma\perftest
drossetti
pushed a commit
that referenced
this pull request
May 12, 2021
The sizeof 'struct ibv_qp' allocated by ibv_create_qp is 160. If the memory holds the 'struct ibv_qp' was allocated at the upper boundary of a memory page, cast it to 'struct verbs_qp', whose size is 360, may across the memory page boundary. It will trigger invalid memory access to the next memory page. The issue can be reproduced with OPA and QIB HCA. For example run over OPA: Server Node: $ ib_read_bw -F -N -n 1000 -u 20 -q 257 -s 4194304 Client Node: $ ib_read_bw -F -N -n 1000 -u 20 -q 257 -s 4194304 <sever> Program received signal SIGSEGV, Segmentation fault. ibv_qp_to_qp_ex (qp=0x5555557a5f10) at libibverbs/verbs.c:624 624 if (vqp->comp_mask & VERBS_QP_EX) (gdb) bt #0 ibv_qp_to_qp_ex (qp=0x5555557a5f10) at libibverbs/verbs.c:624 #1 0x000055555556af4a in create_reg_qp_main (ctx=ctx@entry=0x7fffffffd500, user_param=user_param@entry=0x7fffffffd670, i=i@entry=21, num_of_qps=num_of_qps@entry=128) at src/perftest_resources.c:1597 #2 0x000055555556b6d7 in create_qp_main (num_of_qps=<optimized out>, i=21, user_param=0x7fffffffd670, ctx=0x7fffffffd500) at src/perftest_resources.c:1613 #3 ctx_init (ctx=0x7fffffffd500, user_param=0x7fffffffd670) at src/perftest_resources.c:1552 #4 0x0000555555558e9c in main (argc=<optimized out>, argv=<optimized out>) at src/read_bw.c:149 624 if (vqp->comp_mask & VERBS_QP_EX) (gdb) p qp $1 = (struct ibv_qp *) 0x5555557a5f10 (gdb) p vqp $2 = (struct verbs_qp *) 0x5555557a5f10 (gdb) p *qp $3 = {context = 0x55555578ad00, qp_context = 0x0, .... (gdb) p *vqp Cannot access memory at address 0x5555557a6000 Signed-off-by: Honggang Li <honli@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create Pull request to review this patch