-
Notifications
You must be signed in to change notification settings - Fork 887
Fix source indexer stage #7694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix source indexer stage #7694
Changes from all commits
46653d0
5c72f52
a021f36
1054f1a
548fdb5
af33baa
4118695
c137d5e
d5d336d
925cb70
7196b93
c6fcf19
e61b345
39efa1e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -78,6 +78,8 @@ variables: | |
| value: $(Build.Arcade.ArtifactsPath)TestResults/$(_BuildConfig)/ | ||
| - name: Build.Arcade.VSIXOutputPath | ||
| value: $(Build.Arcade.ArtifactsPath)VSIX | ||
| - name: _WindowsBuildScript | ||
| value: $(Build.SourcesDirectory)/build.cmd -ci -NativeToolsOnMachine | ||
|
|
||
| # Enable extraction of published outputs for analysis | ||
| - name: GDN_EXTRACT_TOOLS | ||
|
|
@@ -125,14 +127,19 @@ variables: | |
| value: true | ||
|
|
||
| # Enable source index only for main branch builds | ||
| - ${{ if and(ne(variables['runAsPublic'], 'true'), notin(variables['Build.Reason'], 'PullRequest'), eq(variables['Build.SourceBranch'], 'refs/heads/main')) }}: | ||
| - name: enableSourceIndex | ||
| value: true | ||
| - ${{ else }}: | ||
| - name: enableSourceIndex | ||
| value: false | ||
| - name: sourceIndexBuildCommand | ||
| value: $(Build.SourcesDirectory)/build.cmd -ci -NativeToolsOnMachine | ||
| - name: sourceIndexCondition | ||
| value: | | ||
| and( | ||
| succeeded(), | ||
| or( | ||
| eq(variables['forceEnableSourceIndex'], 'true'), | ||
| and( | ||
| ne(variables['runAsPublic'], 'true'), | ||
| notin(variables['Build.Reason'], 'PullRequest'), | ||
| eq(variables['Build.SourceBranch'], 'refs/heads/main') | ||
| ) | ||
| ) | ||
| ) | ||
|
|
||
| resources: | ||
| repositories: | ||
|
|
@@ -175,9 +182,16 @@ extends: | |
| manifests: true | ||
| enableMicrobuild: true | ||
| enableTelemetry: true | ||
| enableSourceIndex: ${{ variables['enableSourceIndex'] }} | ||
| enableSourceIndex: true | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this mean that it will enable source index updating even for PRs now?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, the condition just moved (because I needed it to depend on a runtime variable |
||
| sourceIndexParams: | ||
| sourceIndexBuildCommand: ${{ variables['sourceIndexBuildCommand'] }} | ||
| condition: ${{ variables['sourceIndexCondition'] }} | ||
| sourceIndexBuildCommand: '' | ||
|
jjonescz marked this conversation as resolved.
|
||
| preSteps: | ||
| - template: /eng/pipelines/templates/RestoreAndBuild.yml | ||
| parameters: | ||
| buildScript: $(_WindowsBuildScript) | ||
| buildConfig: Debug | ||
| repoLogPath: $(Build.SourcesDirectory)/artifacts/log/Debug | ||
| runAsPublic: ${{ variables['runAsPublic'] }} | ||
| # Publish test logs | ||
| enablePublishTestResults: true | ||
|
|
@@ -201,7 +215,7 @@ extends: | |
| os: windows | ||
|
|
||
| variables: | ||
| - _buildScript: $(Build.SourcesDirectory)/build.cmd -ci -NativeToolsOnMachine | ||
| - _buildScript: $(_WindowsBuildScript) | ||
|
|
||
| templateContext: | ||
| outputs: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| parameters: | ||
| - name: buildScript | ||
| type: string | ||
| - name: buildConfig | ||
| type: string | ||
| - name: repoLogPath | ||
| type: string | ||
| - name: warnAsError | ||
| type: number | ||
| default: 1 | ||
|
|
||
| steps: | ||
| - task: NodeTool@0 | ||
| displayName: Add NodeJS/npm | ||
| inputs: | ||
| versionSpec: "20.x" | ||
| checkLatest: true | ||
|
|
||
| - script: ${{ parameters.buildScript }} | ||
| -restore | ||
| -warnAsError ${{ parameters.warnAsError }} | ||
| /bl:${{ parameters.repoLogPath }}/restore.binlog | ||
| displayName: Restore | ||
|
|
||
| - pwsh: | | ||
| $(Build.SourcesDirectory)/scripts/Slngen.ps1 -All -NoLaunch | ||
| displayName: Create solution | ||
|
|
||
| - script: ${{ parameters.buildScript }} | ||
| -restore | ||
| -warnAsError ${{ parameters.warnAsError }} | ||
| /bl:${{ parameters.repoLogPath }}/restore2.binlog | ||
| displayName: Restore solution | ||
|
|
||
| - script: ${{ parameters.buildScript }} | ||
| -build | ||
| -configuration ${{ parameters.buildConfig }} | ||
| -warnAsError ${{ parameters.warnAsError }} | ||
| /bl:${{ parameters.repoLogPath }}/build.binlog | ||
| $(_OfficialBuildIdArgs) | ||
|
jjonescz marked this conversation as resolved.
|
||
| displayName: Build | ||
Uh oh!
There was an error while loading. Please reload this page.