-
Notifications
You must be signed in to change notification settings - Fork 33
Add $floor arithmetic expression tests #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danielfrankcom
wants to merge
3
commits into
documentdb:main
Choose a base branch
from
danielfrankcom:pr/floor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
241 changes: 241 additions & 0 deletions
241
...s/compatibility/tests/core/operator/expressions/arithmetic/floor/test_floor_boundaries.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,241 @@ | ||
| """Tests for $floor at representable-range, subnormal, and decimal128 exponent boundaries.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import pytest | ||
| from bson import Decimal128, Int64 | ||
|
|
||
| from documentdb_tests.compatibility.tests.core.operator.expressions.utils.expression_test_case import ( # noqa: E501 | ||
| ExpressionTestCase, | ||
| ) | ||
| from documentdb_tests.compatibility.tests.core.operator.expressions.utils.utils import ( | ||
| assert_expression_result, | ||
| execute_expression_with_insert, | ||
| ) | ||
| from documentdb_tests.framework.parametrize import pytest_params | ||
| from documentdb_tests.framework.test_constants import ( | ||
| DECIMAL128_JUST_ABOVE_HALF, | ||
| DECIMAL128_JUST_BELOW_HALF, | ||
| DECIMAL128_LARGE_EXPONENT, | ||
| DECIMAL128_MANY_TRAILING_ZEROS, | ||
| DECIMAL128_MAX, | ||
| DECIMAL128_MIN, | ||
| DECIMAL128_NAN, | ||
| DECIMAL128_SMALL_EXPONENT, | ||
| DECIMAL128_TRAILING_ZERO, | ||
| DECIMAL128_ZERO, | ||
| DOUBLE_JUST_ABOVE_HALF, | ||
| DOUBLE_JUST_BELOW_HALF, | ||
| DOUBLE_MAX_SAFE_INTEGER, | ||
| DOUBLE_MIN_NEGATIVE_SUBNORMAL, | ||
| DOUBLE_MIN_SUBNORMAL, | ||
| DOUBLE_NEAR_MAX, | ||
| DOUBLE_NEAR_MIN, | ||
| DOUBLE_PRECISION_LOSS, | ||
| DOUBLE_ZERO, | ||
| INT32_MAX, | ||
| INT32_MIN, | ||
| INT32_OVERFLOW, | ||
| INT32_UNDERFLOW, | ||
| INT64_MAX, | ||
| INT64_MAX_MINUS_1, | ||
| INT64_MIN, | ||
| INT64_MIN_PLUS_1, | ||
| ) | ||
|
|
||
| # Property [Integer Boundaries]: floor preserves integer-type values at representable-range | ||
| # boundaries, and a value just past the int32 range stays a long. | ||
| FLOOR_INT_BOUNDARY_TESTS: list[ExpressionTestCase] = [ | ||
| ExpressionTestCase( | ||
| "boundary_int32_max", | ||
| doc={"value": INT32_MAX}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=INT32_MAX, | ||
| msg="$floor should return INT32_MAX unchanged as an int", | ||
| ), | ||
| ExpressionTestCase( | ||
| "boundary_int32_min", | ||
| doc={"value": INT32_MIN}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=INT32_MIN, | ||
| msg="$floor should return INT32_MIN unchanged as an int", | ||
| ), | ||
| ExpressionTestCase( | ||
| "boundary_int32_overflow", | ||
| doc={"value": INT32_OVERFLOW}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=Int64(INT32_OVERFLOW), | ||
| msg="$floor should return a value just above the int32 range unchanged as a long", | ||
| ), | ||
| ExpressionTestCase( | ||
| "boundary_int32_underflow", | ||
| doc={"value": INT32_UNDERFLOW}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=Int64(INT32_UNDERFLOW), | ||
| msg="$floor should return a value just below the int32 range unchanged as a long", | ||
| ), | ||
| ExpressionTestCase( | ||
| "boundary_int64_max", | ||
| doc={"value": INT64_MAX}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=INT64_MAX, | ||
| msg="$floor should return INT64_MAX unchanged as a long", | ||
| ), | ||
| ExpressionTestCase( | ||
| "boundary_int64_max_minus_1", | ||
| doc={"value": INT64_MAX_MINUS_1}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=INT64_MAX_MINUS_1, | ||
| msg="$floor should return INT64_MAX-1 unchanged as a long", | ||
| ), | ||
| ExpressionTestCase( | ||
| "boundary_int64_min", | ||
| doc={"value": INT64_MIN}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=INT64_MIN, | ||
| msg="$floor should return INT64_MIN unchanged as a long", | ||
| ), | ||
| ExpressionTestCase( | ||
| "boundary_int64_min_plus_1", | ||
| doc={"value": INT64_MIN_PLUS_1}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=INT64_MIN_PLUS_1, | ||
| msg="$floor should return INT64_MIN+1 unchanged as a long", | ||
| ), | ||
| ] | ||
|
|
||
| # Property [Double Boundaries]: floor handles subnormal and extreme double magnitudes, | ||
| # including values on either side of the 0.5 rounding boundary and at the integer-representability | ||
| # limit, where doubles have no fractional part and floor is an identity. | ||
| FLOOR_DOUBLE_BOUNDARY_TESTS: list[ExpressionTestCase] = [ | ||
| ExpressionTestCase( | ||
| "boundary_double_min_subnormal", | ||
| doc={"value": DOUBLE_MIN_SUBNORMAL}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=DOUBLE_ZERO, | ||
| msg="$floor should floor the smallest positive subnormal double to DOUBLE_ZERO", | ||
| ), | ||
| ExpressionTestCase( | ||
| "boundary_double_min_negative_subnormal", | ||
| doc={"value": DOUBLE_MIN_NEGATIVE_SUBNORMAL}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=-1.0, | ||
| msg="$floor should floor the smallest negative subnormal double to -1.0", | ||
| ), | ||
| ExpressionTestCase( | ||
| "boundary_double_near_min", | ||
| doc={"value": DOUBLE_NEAR_MIN}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=DOUBLE_ZERO, | ||
| msg="$floor should floor a near-min positive double to DOUBLE_ZERO", | ||
| ), | ||
| ExpressionTestCase( | ||
| "boundary_double_near_max", | ||
| doc={"value": DOUBLE_NEAR_MAX}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=DOUBLE_NEAR_MAX, | ||
| msg="$floor should return a near-max whole-magnitude double unchanged", | ||
| ), | ||
| ExpressionTestCase( | ||
| "boundary_double_max_safe_integer", | ||
| doc={"value": float(DOUBLE_MAX_SAFE_INTEGER)}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=float(DOUBLE_MAX_SAFE_INTEGER), | ||
| msg="$floor should return the max safe integer double unchanged, having no fractional part", | ||
| ), | ||
| ExpressionTestCase( | ||
| "boundary_double_precision_loss", | ||
| doc={"value": float(DOUBLE_PRECISION_LOSS)}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=float(DOUBLE_PRECISION_LOSS), | ||
| msg="$floor should return a precision-loss double unchanged, having no fractional part", | ||
| ), | ||
| ExpressionTestCase( | ||
| "boundary_double_just_below_half", | ||
| doc={"value": DOUBLE_JUST_BELOW_HALF}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=DOUBLE_ZERO, | ||
| msg="$floor should floor a double just below 0.5 to DOUBLE_ZERO", | ||
| ), | ||
| ExpressionTestCase( | ||
| "boundary_double_just_above_half", | ||
| doc={"value": DOUBLE_JUST_ABOVE_HALF}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=DOUBLE_ZERO, | ||
| msg="$floor should floor a double just above 0.5 to DOUBLE_ZERO", | ||
| ), | ||
| ] | ||
|
|
||
| # Property [Decimal Boundaries]: floor handles decimal128 exponent extremes, trailing-zero | ||
| # normalization, and values around the 0.5 boundary, returning NaN when the magnitude overflows. | ||
| FLOOR_DECIMAL_BOUNDARY_TESTS: list[ExpressionTestCase] = [ | ||
| ExpressionTestCase( | ||
| "boundary_decimal_max", | ||
| doc={"value": DECIMAL128_MAX}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=DECIMAL128_NAN, | ||
| msg="$floor should return NaN for the maximum decimal128 magnitude", | ||
| ), | ||
| ExpressionTestCase( | ||
| "boundary_decimal_min", | ||
| doc={"value": DECIMAL128_MIN}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=DECIMAL128_NAN, | ||
| msg="$floor should return NaN for the minimum decimal128 magnitude", | ||
| ), | ||
| ExpressionTestCase( | ||
| "boundary_decimal_large_exponent", | ||
| doc={"value": DECIMAL128_LARGE_EXPONENT}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=DECIMAL128_NAN, | ||
| msg="$floor should return NaN for a decimal128 with a large positive exponent", | ||
| ), | ||
| ExpressionTestCase( | ||
| "boundary_decimal_small_exponent", | ||
| doc={"value": DECIMAL128_SMALL_EXPONENT}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=DECIMAL128_ZERO, | ||
| msg="$floor should floor a decimal128 with a large negative exponent to 0", | ||
| ), | ||
| ExpressionTestCase( | ||
| "boundary_decimal_trailing_zero", | ||
| doc={"value": DECIMAL128_TRAILING_ZERO}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=Decimal128("1"), | ||
| msg="$floor should normalize a whole decimal128 with a trailing zero to 1", | ||
| ), | ||
| ExpressionTestCase( | ||
| "boundary_decimal_many_trailing_zeros", | ||
| doc={"value": DECIMAL128_MANY_TRAILING_ZEROS}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=Decimal128("1"), | ||
| msg="$floor should normalize a whole decimal128 with many trailing zeros to 1", | ||
| ), | ||
| ExpressionTestCase( | ||
| "boundary_decimal_just_below_half", | ||
| doc={"value": DECIMAL128_JUST_BELOW_HALF}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=DECIMAL128_ZERO, | ||
| msg="$floor should floor a decimal128 just below 0.5 to 0", | ||
| ), | ||
| ExpressionTestCase( | ||
| "boundary_decimal_just_above_half", | ||
| doc={"value": DECIMAL128_JUST_ABOVE_HALF}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=DECIMAL128_ZERO, | ||
| msg="$floor should floor a decimal128 just above 0.5 to 0", | ||
| ), | ||
| ] | ||
|
|
||
| FLOOR_BOUNDARY_TESTS = ( | ||
| FLOOR_INT_BOUNDARY_TESTS + FLOOR_DOUBLE_BOUNDARY_TESTS + FLOOR_DECIMAL_BOUNDARY_TESTS | ||
| ) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("test", pytest_params(FLOOR_BOUNDARY_TESTS)) | ||
| def test_floor_boundaries(collection, test): | ||
| """Test $floor at numeric boundaries.""" | ||
| result = execute_expression_with_insert(collection, test.expression, test.doc) | ||
| assert_expression_result( | ||
| result, expected=test.expected, error_code=test.error_code, msg=test.msg | ||
| ) | ||
152 changes: 152 additions & 0 deletions
152
...b_tests/compatibility/tests/core/operator/expressions/arithmetic/floor/test_floor_core.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,152 @@ | ||
| """Tests for $floor core flooring behavior across integer, double, and decimal128 inputs.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import pytest | ||
| from bson import Decimal128, Int64 | ||
|
|
||
| from documentdb_tests.compatibility.tests.core.operator.expressions.utils.expression_test_case import ( # noqa: E501 | ||
| ExpressionTestCase, | ||
| ) | ||
| from documentdb_tests.compatibility.tests.core.operator.expressions.utils.utils import ( | ||
| assert_expression_result, | ||
| execute_expression_with_insert, | ||
| ) | ||
| from documentdb_tests.framework.parametrize import pytest_params | ||
| from documentdb_tests.framework.test_constants import ( | ||
| DECIMAL128_NEGATIVE_ONE_AND_HALF, | ||
| DECIMAL128_NEGATIVE_ZERO, | ||
| DECIMAL128_ONE_AND_HALF, | ||
| DECIMAL128_ZERO, | ||
| DOUBLE_NEGATIVE_ZERO, | ||
| DOUBLE_ZERO, | ||
| INT64_ZERO, | ||
| ) | ||
|
|
||
| # Property [Integer Identity]: floor returns integer inputs unchanged, preserving int/long type. | ||
| FLOOR_INTEGER_TESTS: list[ExpressionTestCase] = [ | ||
| ExpressionTestCase( | ||
| "identity_positive_int32", | ||
| doc={"value": 1}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=1, | ||
| msg="$floor should return a positive int32 unchanged", | ||
| ), | ||
| ExpressionTestCase( | ||
| "identity_negative_int32", | ||
| doc={"value": -1}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=-1, | ||
| msg="$floor should return a negative int32 unchanged", | ||
| ), | ||
| ExpressionTestCase( | ||
| "identity_zero_int32", | ||
| doc={"value": 0}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=0, | ||
| msg="$floor should return int32 zero unchanged", | ||
| ), | ||
| ExpressionTestCase( | ||
| "identity_positive_int64", | ||
| doc={"value": Int64(1)}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=Int64(1), | ||
| msg="$floor should return a positive int64 unchanged", | ||
| ), | ||
| ExpressionTestCase( | ||
| "identity_negative_int64", | ||
| doc={"value": Int64(-1)}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=Int64(-1), | ||
| msg="$floor should return a negative int64 unchanged", | ||
| ), | ||
| ExpressionTestCase( | ||
| "identity_zero_int64", | ||
| doc={"value": INT64_ZERO}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=INT64_ZERO, | ||
| msg="$floor should return int64 zero unchanged", | ||
| ), | ||
| ] | ||
|
|
||
| # Property [Double Flooring]: floor rounds a double down to the nearest integer, returning a double. | ||
| FLOOR_DOUBLE_TESTS: list[ExpressionTestCase] = [ | ||
| ExpressionTestCase( | ||
| "double_positive", | ||
| doc={"value": 1.5}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=1.0, | ||
| msg="$floor should round a positive double down", | ||
| ), | ||
| ExpressionTestCase( | ||
| "double_negative", | ||
| doc={"value": -1.5}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=-2.0, | ||
| msg="$floor should round a negative double down, away from zero", | ||
| ), | ||
| ExpressionTestCase( | ||
| "double_zero", | ||
| doc={"value": DOUBLE_ZERO}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=DOUBLE_ZERO, | ||
| msg="$floor should return double zero unchanged", | ||
| ), | ||
| ExpressionTestCase( | ||
| "double_negative_zero", | ||
| doc={"value": DOUBLE_NEGATIVE_ZERO}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=DOUBLE_NEGATIVE_ZERO, | ||
| msg="$floor should preserve negative zero for a double", | ||
| ), | ||
| ] | ||
|
|
||
| # Property [Decimal Flooring]: floor rounds a decimal128 down, returning decimal128. | ||
| FLOOR_DECIMAL_TESTS: list[ExpressionTestCase] = [ | ||
| ExpressionTestCase( | ||
| "decimal_positive_fraction", | ||
| doc={"value": DECIMAL128_ONE_AND_HALF}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=Decimal128("1"), | ||
| msg="$floor should round a positive decimal128 down", | ||
| ), | ||
| ExpressionTestCase( | ||
| "decimal_negative_fraction", | ||
| doc={"value": DECIMAL128_NEGATIVE_ONE_AND_HALF}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=Decimal128("-2"), | ||
| msg="$floor should round a negative decimal128 down, away from zero", | ||
| ), | ||
| ExpressionTestCase( | ||
| "decimal_whole", | ||
| doc={"value": Decimal128("1")}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=Decimal128("1"), | ||
| msg="$floor should return a whole decimal128 unchanged", | ||
| ), | ||
| ExpressionTestCase( | ||
| "decimal_zero", | ||
| doc={"value": DECIMAL128_ZERO}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=DECIMAL128_ZERO, | ||
| msg="$floor should return decimal128 zero unchanged", | ||
| ), | ||
| ExpressionTestCase( | ||
| "decimal_negative_zero", | ||
| doc={"value": DECIMAL128_NEGATIVE_ZERO}, | ||
| expression={"$floor": ["$value"]}, | ||
| expected=DECIMAL128_NEGATIVE_ZERO, | ||
| msg="$floor should preserve negative zero for a decimal128", | ||
| ), | ||
| ] | ||
|
|
||
| FLOOR_CORE_TESTS = FLOOR_INTEGER_TESTS + FLOOR_DOUBLE_TESTS + FLOOR_DECIMAL_TESTS | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("test", pytest_params(FLOOR_CORE_TESTS)) | ||
| def test_floor_core(collection, test): | ||
| """Test $floor core flooring behavior.""" | ||
| result = execute_expression_with_insert(collection, test.expression, test.doc) | ||
| assert_expression_result( | ||
| result, expected=test.expected, error_code=test.error_code, msg=test.msg | ||
| ) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.