Add abs expression tests#659
Conversation
Co-authored-by: Victor Tsang <vitsangp@amazon.com> Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
|
🤖 Auto-triaged by documentdb-triage-tool. Applied: Reasoningcomponent from path globs (test-coverage); effort from diff stats (724+0 LOC, 7 files); LLM failed: Invalid response body while trying to fetch https://api.anthropic.com/v1/messages: Premature close If a label is wrong, remove it manually and ping |
|
I think we should probably add in docStrings for these files |
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Assuming you mean module docstrings here, since there are already docstrings for the property groups. Just pushed a change with those, please let me know if you meant something else. |
That is what I meant! Sorry should've been clearer |
PatersonProjects
left a comment
There was a problem hiding this comment.
It looks good to me, but you may want to consider adding a nested field path test?
{"a": [{"b": -1}, {"b": -2}]}, expression {"$abs": "$a.b"}
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
|
Are tests in other contexts per https://github.com/documentdb/functional-tests/blob/main/docs/testing/TEST_COVERAGE.md#11-expression-operator-in-pipeline-contexts in scope for this change? |
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
I think this is out of scope for expression-level changes, it falls within the scope of integration tests for the consuming aspects, like |
This change adds tests for the
absexpression. It was originally authored by @vic-tsang.Closes #272