Skip to content

Add getClusterParameter tests#656

Open
PatersonProjects wants to merge 16 commits into
documentdb:mainfrom
PatersonProjects:getClusterParameter_tests
Open

Add getClusterParameter tests#656
PatersonProjects wants to merge 16 commits into
documentdb:mainfrom
PatersonProjects:getClusterParameter_tests

Conversation

@PatersonProjects

Copy link
Copy Markdown
Contributor

This PR adds the tests for the getClusterParameter administration command.

Ref: Issue #42, #422

Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
…issing coverage

Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
@PatersonProjects PatersonProjects requested a review from a team as a code owner June 29, 2026 21:44
@documentdb-triage-tool

Copy link
Copy Markdown

🤖 Auto-triaged by documentdb-triage-tool.

Applied: compatibility test, enhancement
Project fields suggested: Component test-coverage · Priority P2 · Effort L · Status Needs Review
Confidence: 0.30 (deterministic)

Reasoning

component from path globs (test-coverage, test-framework); effort from diff stats (362+0 LOC, 8 files); LLM failed: Invalid response body while trying to fetch https://api.anthropic.com/v1/messages: Premature close

If a label is wrong, remove it manually and ping @patty-chow so the rules can be tuned. The bot will not re-label items that already have component labels.

@documentdb-triage-tool documentdb-triage-tool Bot added compatibility test Compatibility test related enhancement New feature or request labels Jun 29, 2026
Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
This reverts commit 014f2bc.

Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
This reverts commit 51a482a.

Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
…-tests

Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
@manojnks

manojnks commented Jul 2, 2026

Copy link
Copy Markdown

@PatersonProjects

Copy link
Copy Markdown
Contributor Author

https://www.mongodb.com/docs/manual/core/sharded-cluster-config-servers/#std-label-sharding-config-server should add test cases for all the parameters?

Looking through that doc page I can't see any additional parameters, but I've added tests for all the ones here that were missing: https://www.mongodb.com/docs/manual/reference/cluster-parameters/

Beyond that list I hesitate to check for direct parameters unless they are directly referenced as included, let me know if I've missed any.

Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
…-tests

Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
@PatersonProjects

Copy link
Copy Markdown
Contributor Author

https://www.mongodb.com/docs/manual/core/sharded-cluster-config-servers/#std-label-sharding-config-server should add test cases for all the parameters?

Looking through that doc page I can't see any additional parameters, but I've added tests for all the ones here that were missing: https://www.mongodb.com/docs/manual/reference/cluster-parameters/

Beyond that list I hesitate to check for direct parameters unless they are directly referenced as included, let me know if I've missed any.

Well, it looks like even the documented parameters are not always included, auditConfig is seemingly not present on local and CI runs. I've kept the other new test but I'm not sure if it should be kept either or if it is a risk of a flaky case, let me know if you would like to me to remove it as well.

Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility test Compatibility test related enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants