Skip to content

Add setParameter tests#650

Open
alinaliBQ wants to merge 9 commits into
documentdb:mainfrom
alinaliBQ:setParameter
Open

Add setParameter tests#650
alinaliBQ wants to merge 9 commits into
documentdb:mainfrom
alinaliBQ:setParameter

Conversation

@alinaliBQ

Copy link
Copy Markdown
Contributor

Add command operator tests for setParameter. Tests database setParameter behavior, output collection, syntax, and errors. Worked with @vic-tsang to get initial set of tests to work with.

@alinaliBQ alinaliBQ marked this pull request as ready for review June 26, 2026 23:08
@alinaliBQ alinaliBQ requested a review from a team as a code owner June 26, 2026 23:08
@documentdb-triage-tool

Copy link
Copy Markdown

🤖 Auto-triaged by documentdb-triage-tool.

Applied: compatibility test, enhancement
Project fields suggested: Component test-coverage · Priority P2 · Effort L · Status Needs Review
Confidence: 0.30 (deterministic)

Reasoning

component from path globs (test-coverage); effort from diff stats (757+0 LOC, 6 files); LLM failed: Invalid response body while trying to fetch https://api.anthropic.com/v1/messages: Premature close

If a label is wrong, remove it manually and ping @patty-chow so the rules can be tuned. The bot will not re-label items that already have component labels.

@documentdb-triage-tool documentdb-triage-tool Bot added compatibility test Compatibility test related enhancement New feature or request labels Jun 26, 2026
@manojnks

manojnks commented Jul 2, 2026

Copy link
Copy Markdown

https://www.mongodb.com/docs/manual/reference/parameters/
only partial of thing available here are tested.
should this feature test all the parameters?

@manojnks

manojnks commented Jul 2, 2026

Copy link
Copy Markdown

AdministrationTestCase this has been introduced for getClusterParameter should use that here?

alinaliBQ added 9 commits July 2, 2026 16:37
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ

Copy link
Copy Markdown
Contributor Author

should this feature test all the parameters?

I believe testing all the parameters is not required for this feature. Since different BSON types are accepted by setParameter, the test suite verifies that the operator works as expected. Also the TEST_COVERAGE.md guide has a "No engine-specific implementation details" rule which excludes the internal parameters such as internalSessionsReapThreshold.

AdministrationTestCase this has been introduced for getClusterParameter should use that here?

I think it is optional since CommandTestCase structure works with setParameter. In general we try to use existing command test cases if possible to avoid conflicts.

@alinaliBQ

Copy link
Copy Markdown
Contributor Author

@manojnks Please let me know if you have any other comments, thanks

@manojnks

manojnks commented Jul 4, 2026

Copy link
Copy Markdown

sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility test Compatibility test related enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants