Skip to content

bake: reject targets inside target blocks#3906

Open
amarkdotdev wants to merge 1 commit into
docker:masterfrom
amarkdotdev:codex/fix-bake-target-validation
Open

bake: reject targets inside target blocks#3906
amarkdotdev wants to merge 1 commit into
docker:masterfrom
amarkdotdev:codex/fix-bake-target-validation

Conversation

@amarkdotdev

Copy link
Copy Markdown

Summary

Testing

  • go test ./bake -count=1

Closes #2437

@amarkdotdev amarkdotdev force-pushed the codex/fix-bake-target-validation branch 2 times, most recently from dca180b to 1f13238 Compare June 15, 2026 15:20
@amarkdotdev

Copy link
Copy Markdown
Author

Gentle ping on this one. It's a small, self-contained fix for #2437: bake now rejects a targets attribute used inside a target block (it belongs in a group block) with a clear "Unsupported argument" diagnostic, instead of silently building. DCO and labeler are green, and go test ./bake -count=1 passes locally (full package suite, including the new TestTargetDisallowsGroupTargetsAttribute).

The build / validate / e2e / codeql workflows are sitting in the "action required" state pending a maintainer's approval to run on this PR. Could a maintainer approve the run and take a look? Happy to address anything that comes up. Closes #2437.

Signed-off-by: Aaron Mark <64331623+amarkdotdev@users.noreply.github.com>
@amarkdotdev amarkdotdev force-pushed the codex/fix-bake-target-validation branch from 1f13238 to ff8b61e Compare June 21, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid bake target syntax still builds

1 participant