added the fifa ranking to each team#143
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a FIFA ranking attribute for teams, persists it in the database, and exposes it through the v1 team JSON representation. It also updates the World Cup 2026 setup rake task to seed rankings for the predefined teams and wraps the setup in a DatabaseViews.run_without_callback block to avoid excessive view refreshes during bulk creation.
Changes:
- Add
teams.rankinginteger column via migration (and schema update). - Include
rankingin the v1 team JSON partial so it’s returned wherever teams are rendered. - Seed team rankings in
world_cup:createand run the task insideDatabaseViews.run_without_callback(then_refresh: true).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/tasks/world_cup.rake | Adds hardcoded FIFA rankings for seeded World Cup teams and updates team records with ranking during setup. |
| db/schema.rb | Reflects the new ranking column on teams and bumps schema version. |
| db/migrate/20260604043212_add_fifa_ranking_to_teams.rb | Adds the ranking integer column to the teams table. |
| app/views/v1/teams/_team.json.jbuilder | Exposes ranking in the v1 team JSON payload. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.