resizer: fix chaos grow to target the EFI System label#24
Merged
Conversation
TestChaosKill's grow phase targeted label "ESP", but the sample fixture labels that partition "EFI System" (its assertions already key on that), so the grow matched no partition. The mismatch predates this work and only surfaces when the opt-in chaos test's grow phase runs. Target the correct label. Signed-off-by: eriknordmark <erik@zededa.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
eriknordmark
marked this pull request as ready for review
July 8, 2026 21:30
Contributor
Author
|
@deitch ready for review when you have a moment — one-line label fix. Thanks! |
deitch
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestChaosKill's grow phase targets partition labelESP, but the samplefixture labels that partition
EFI System(and the test's own assertionskey on
EFI System). The grow therefore matches no partition and theopt-in chaos test fails with "no disks found matching specified
partitions". This is a pre-existing mismatch; it only surfaces when the
chaos test's grow phase is actually run (
RESIZER_CHAOS=1/CHAOS_GPT_DELAY). Target the correct label.One-line fix, independent of any feature work.