gpt: test round-trip of two partitions with the same name#414
Merged
Conversation
A GPT partition is keyed by its unique GUID; the name field carries no uniqueness constraint, so a consumer that must pick one of two identically-named partitions has to rely on the GUID. Add a test that writes two "EFI System" partitions with distinct GUIDs, reads the table back, and asserts the labels stay identical while the per-entry GUIDs are preserved and distinct. Signed-off-by: eriknordmark <erik@zededa.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
eriknordmark
marked this pull request as ready for review
July 8, 2026 19:05
Contributor
Author
|
@deitch this is ready for review — a small regression guard that two GPT partitions sharing a name but with distinct GUIDs round-trip through |
deitch
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A GPT partition is keyed by its unique GUID; the name field carries no
uniqueness constraint. A consumer that must select one of two
identically-named partitions therefore has to rely on the GUID surviving a
write/read round-trip. This adds a test that writes two
"EFI System"partitions with distinct GUIDs, reads the table back, and asserts the
labels stay identical while the per-entry GUIDs are preserved and distinct.
Test-only; no library change. Draft/WIP pending review — motivated by
downstream partition-selection-by-GUID work.