chore(detector): remove stale fnm not-implemented comment, sentinel.go pkg-doc collision, dead config.FileOverlay#114
Merged
dipto0321 merged 1 commit intoJul 5, 2026
Conversation
dipto0321
force-pushed
the
chore/detector/remove-stale-fnm-notimplemented-sentinel-pkgdoc-filoverlay
branch
from
82027f7 to
5592e84
Compare
Residual stale-comment / dead-code cleanups from the 2026-07-03 re-review that didn't belong in any of the active fix-wave PRs. All deletions / docstring edits — no behavior change. - internal/detector/fnm.go: delete ErrFNMNotImplemented (zero call sites, no tests, mutations real since PR #56); rewrite the FNM struct doc to describe the actual surface (detection + mutations + layout queries) instead of "Phase 1 only, not implemented"; drop the "left as stubs in Phase 1" paragraph from the mutation section. - internal/packages/sentinel.go: demote "// Package sentinel implements..." to "// Sentinel file handling: ..." — godoc attributes package-doc comments to the actual package name (`packages`), so the rendered godoc was wrong. Verified no canonical "// Package packages ..." comment exists elsewhere, so the package isn't left undocumented. - internal/config/resolve.go: delete superseded FileOverlay() (the coarse all-fields overlay that marked explicit-zero values as set — exactly the bug FileOverlayFromNode was introduced to fix in #85). Update the Overlay type's doc comment to point at FileOverlayFromNode as the file-layer builder. Closes #104. Co-Authored-By: puku-ai-2.8 <noreply@puku.sh>
dipto0321
force-pushed
the
chore/detector/remove-stale-fnm-notimplemented-sentinel-pkgdoc-filoverlay
branch
from
5592e84 to
b2a95b6
Compare
|
✔️ b2a95b6 - Conventional commits check succeeded. |
dipto0321
deleted the
chore/detector/remove-stale-fnm-notimplemented-sentinel-pkgdoc-filoverlay
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Residual stale-comment / dead-code cleanups from the 2026-07-03 re-review. All deletions / docstring edits — no behavior change.
internal/detector/fnm.go: deleteErrFNMNotImplemented(zero call sites repo-wide, mutations have been real since PR feat(cli): post-upgrade cleanup prompt + native mutation commands #56); rewrite theFNMstruct doc to describe the actual implemented surface (detection + mutations + layout queries) instead of "Phase 1 only, mutations not implemented"; drop the "left as stubs in Phase 1" paragraph from the mutation section.internal/packages/sentinel.go: demote// Package sentinel implements…to// Sentinel file handling: …— godoc attributes package-doc comments to the actual package (packages), so the rendered godoc was wrong. Verified no canonical// Package packages …comment exists elsewhere, so the move doesn't leave the package undocumented.internal/config/resolve.go: delete supersededFileOverlay()(the coarse all-fields overlay that marked explicit-zero values as set — exactly the bugFileOverlayFromNodewas introduced to fix in fix(packages): validate manager name against allowlist in restore/diff #85). Update theOverlaytype's doc comment to point atFileOverlayFromNodeas the file-layer builder.Verification
grep -rn "ErrFNMNotImplemented\|not implemented" internal/detector/fnm.go→ no hits.go doc ./internal/packagesshows no package-level doc comment (was previously wrongly attributed).grep -rn "func FileOverlay\b" .→ no hits; onlyFileOverlayFromNodereferences remain.make cigreen (golangci-lint: 0 issues; race + coverage: 62.8%).Closes #104.