feat: expose Radiation.GetLinearPolarRate / SetLinearPolarRate and clock accessors - #93
Open
vincefn wants to merge 2 commits into
Open
feat: expose Radiation.GetLinearPolarRate / SetLinearPolarRate and clock accessors#93vincefn wants to merge 2 commits into
vincefn wants to merge 2 commits into
Conversation
…adiation - Add Python bindings for Radiation::GetLinearPolarRate() and Radiation::SetLinearPolarRate() (available in current libobjcryst) - Add GetClockWavelength() and GetClockRadiation() bindings (were missing) - Add GetClockLinearPolarRate() guarded behind LIBOBJCRYST_VERSION >= 2026002000000LL (requires libobjcryst update with vincefn/objcryst PR #79) - Add test_radiation.py::testLinearPolarRate Closes #38 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR address?
Issue #38 — the linear polarisation rate was not accessible from Python.
What was done
Radiation.GetLinearPolarRate()andRadiation.SetLinearPolarRate()(already in current libobjcryst).Radiation.GetClockWavelength()andRadiation.GetClockRadiation()(were missing).Radiation.GetClockLinearPolarRate()behind aLIBOBJCRYST_VERSION >= 2026002000000LLguard — this requires vincefn/objcryst PR #79 to be picked up by a future libobjcryst release.tests/test_radiation.py::testLinearPolarRate.Dependency note
The polarisation-correction recalculation fix (so that changing the linear polar rate actually triggers a recalc) depends on vincefn/objcryst PR #79, which is merged upstream but not yet in a libobjcryst release. The new bindings work with the current libobjcryst; the full fix will be active once libobjcryst is updated.
Closes #38