Fix displ_transl toggle in quick_fit_profile - #92
Open
vincefn wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR address?
Fixes #83.
quick_fit_profile(displ_transl=True)incorrectly fixed2ThetaDispland2ThetaTransp, so they were not refined.This PR changes those flags to
Falseso both parameters are actually refined whendispl_transl=True. It also adds:tests/test_powderpattern.pynews/83.rstWhat should the reviewer(s) do?
Check that the toggle logic in
quick_fit_profilenow matches the other refinement toggles and that the new test captures the regression.