Shard the long-running CORE runs of contracts-dfcc and jbmc-strings#9086
Open
tautschnig wants to merge 1 commit into
Open
Shard the long-running CORE runs of contracts-dfcc and jbmc-strings#9086tautschnig wants to merge 1 commit into
tautschnig wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reduces wall-clock time and intermittent macOS runner timeouts by sharding two long-running regression suites’ CORE ctest entries into multiple parallel shards, using the existing add_sharded_test_pl_profile helper.
Changes:
- Shard
contracts-dfccCORE into 4 parallel ctest tests (each retaining the previous 1800s timeout), and apply thesmt2_solverPATHenvironment to each shard. - Shard
jbmc-stringsCORE into 4 parallel ctest tests (each retaining the previous 1800s timeout), mirroring the already-sharded symex-driven profile. - Broaden JBMC regression log ignore pattern to cover shard log filenames (
tests-*.log).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
regression/contracts-dfcc/CMakeLists.txt |
Replaces a single long CORE test with 4 sharded CORE tests (plus explicit THOROUGH/FUTURE/KNOWNBUG), and applies the smt2_solver PATH env to each shard. |
jbmc/regression/jbmc-strings/CMakeLists.txt |
Converts the suite’s CORE run into 4 shards using add_sharded_test_pl_profile, while keeping other levels as single tests. |
.gitignore |
Ignores JBMC shard log files via jbmc/regression/**/tests-*.log. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #9086 +/- ##
========================================
Coverage 80.69% 80.69%
========================================
Files 1714 1714
Lines 189597 189597
Branches 73 73
========================================
+ Hits 152987 152988 +1
+ Misses 36610 36609 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
These two suites are the slowest non-sharded CORE ctest entries and, at a single 30-minute-capped test each, intermittently time out on the slower and highly variable macOS-14 runners (their per-run time there swings roughly 2-3x). Their timeouts (1800s) are already above the 1200s default, so the right remedy is sharding rather than a further timeout bump. Split each suite's CORE profile into 4 parallel shards via test.pl's --shard option. Add an add_sharded_test_pl_tests macro (next to add_test_pl_tests) that shards the CORE profile and registers THOROUGH/FUTURE/KNOWNBUG as single tests, so both suites share a single definition of the pattern rather than hand-expanding it; it builds on the existing add_sharded_test_pl_profile helper. The smaller pieces run in parallel as separate ctest entries instead of one indivisible test, so they no longer dominate the job wall-clock or approach the per-test timeout. Each shard keeps the suite's previous 30-minute cap, which is now ample headroom. The contracts-dfcc smt2_solver PATH environment is applied to each shard, and the THOROUGH/FUTURE/KNOWNBUG levels remain single tests. Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
3b2b07a to
4cd5fce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two suites are the slowest non-sharded CORE ctest entries and, at a single 30-minute-capped test each, intermittently time out on the slower and highly variable macOS-14 runners (their per-run time there swings roughly 2-3x). Their timeouts (1800s) are already above the 1200s default, so the right remedy is sharding rather than a further timeout bump.
Split each suite's CORE profile into 4 parallel shards via test.pl's --shard option, reusing the add_sharded_test_pl_profile helper already used for the jbmc-strings symex-driven-lazy-loading profile. The smaller pieces run in parallel as separate ctest entries instead of one indivisible test, so they no longer dominate the job wall-clock or approach the per-test timeout. Each shard keeps the suite's previous 30-minute cap, which is now ample headroom.
The contracts-dfcc smt2_solver PATH environment is applied to each shard, and the THOROUGH/FUTURE/KNOWNBUG levels remain single tests.