fix: fixed unbound lineHeight during rendering - #3498
Open
Silvenga wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 50d8038 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Silvenga
force-pushed
the
fix-dynamic-render
branch
from
August 18, 2026 13:53
4fa46c1 to
50d8038
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
<Text render={() => "blah"} />thelineHeightmultiplies unbounded during the rendering process - causing (I believe) the element to be clipped out, no longer present visually or within the PDF text.The fix in this PR is to stop the recalculation loop of going to higher and higher multiples of
lineHeightby, on the first pass, convert the value to an absolute value.Resolves #3083 and #3402