Bump DFX_IC_COMMIT to pick up dfx-core-vendored fix, revert #614 workaround - #616
Merged
Merged
Conversation
Bump DFX_IC_COMMIT to dfinity/ic@1e1a813, which includes dfinity/ic#10914 (merged as aeb799e3dd3b5e0cecb628f2070bcb2aa7bc8400), fixing local-network resolution in the vendored dfx-core used by the sns CLI. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011Zr39tUEEpEqc45jdQ5HDi
Closed
daniel-wong-dfinity-org-twin
approved these changes
Aug 10, 2026
daniel-wong-dfinity-org-twin
marked this pull request as ready for review
August 10, 2026 17:49
daniel-wong-dfinity-org-twin
enabled auto-merge (squash)
August 10, 2026 17:50
Apply Daniel Wong's suggested edit: pick up a newer dfinity/ic master commit (3ec5d044f5dc45a93943ec14258891a1c3c272be, 2026-08-07) than the one this PR originally pinned. Confirmed it is a real commit on dfinity/ic's master and still includes the dfx-core-vendored fix from ic#10914 (aeb799e3dd3b5e0cecb628f2070bcb2aa7bc8400 is an ancestor). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011Zr39tUEEpEqc45jdQ5HDi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
DFX_IC_COMMITinbin/versions.bashfrom42413a1c7dbabc98ae3abc6124a9b96d3c0985feto1e1a813088f35d1024f9591a0a55617d37f0fb9e(current tip ofdfinity/ic'smaster, at the time this PR was opened, with a green "Kickoff" CI run). This commit includes fix(sns-cli): resolve shared local network config in vendored dfx-core ic#10914, merged asaeb799e3dd3b5e0cecb628f2070bcb2aa7bc8400.git revert 11428563bf073e60e60ee9dbe7cb4eccf9b9d419, clean single-commit revert): restoresbin/dfx-sns-wasm-upload'ssns add-sns-wasm-for-tests --network "$DFX_NETWORK"call and removes theDFX_NNS_URL/dfx-network-providerworkaround that fix(sns): pass the network URL to the sns CLI when uploading SNS wasms #614 added.Why
dfinity/ic#10914 fixes local-network resolution in the vendored
dfx-coresubset (rs/sns/dfx-core-vendored) used by thesnsCLI: it now correctly falls back to the shared~/.config/dfx/networks.json(127.0.0.1:8080, this repo's convention) when the nearestdfx.jsondoesn't declare its ownnetworks.local, instead of hardcoding the dfx project default127.0.0.1:8000.That hardcoded-default bug is exactly what #614 worked around, by resolving the network name to a literal URL via
dfx-network-providerbefore callingsns add-sns-wasm-for-tests. Now that the underlying bug is fixed upstream and this PR'sDFX_IC_COMMITbump picks it up, the workaround is no longer needed — passing the network namelocaldirectly works again, matching how the rest of thesnsCLI callsites in this repo behave.Verification
git merge-base --is-ancestor aeb799e3dd3b5e0cecb628f2070bcb2aa7bc8400 1e1a813088f35d1024f9591a0a55617d37f0fb9econfirms the pinned commit includes the dfx-core-vendored fix.shellcheck -e SC1090 -e SC2119 -e SC1091 -e SC2121 -e SC2155 -e SC2094 -e SC2015 bin/versions.bash bin/dfx-sns-wasm-upload(this repo's own.github/workflows/checks.ymlflags) passes clean.dfx start/replica against the pinned IC commit — not reproducible in this environment, hence opening as a draft PR pending CI.Fixes/relates to dfinity/ic#10914, reverts #614.
Requested by: Daniel Wong
🤖 Generated with Claude Code
https://claude.ai/code/session_011Zr39tUEEpEqc45jdQ5HDi
Generated by Claude Code