Skip to content

chore: bump secp256k1-sys and bitcoin#10649

Merged
nmattia merged 2 commits into
masterfrom
nm-secp-btc-bump
Jul 9, 2026
Merged

chore: bump secp256k1-sys and bitcoin#10649
nmattia merged 2 commits into
masterfrom
nm-secp-btc-bump

Conversation

@nmattia

@nmattia nmattia commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

This bumps some crates and allows us to remove some duplication in the lockfile.

@nmattia nmattia requested review from a team as code owners July 3, 2026 12:39
@github-actions github-actions Bot added the chore label Jul 3, 2026
@zeropath-ai

zeropath-ai Bot commented Jul 3, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to ef54517.

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► Cargo.Bazel.toml.lock
    Update secp256k1 and windows-sys versions across multiple crates
► bazel/rust.MODULE.bazel
    Update secp256k1 and feature flags/versions
► packages/ic-secp256k1/Cargo.toml
    Bump secp256k1 to 0.29 and adjust dependencies/features
► packages/ic-secp256k1/tests/tests.rs
    Update imports and usage to new API (TapNodeHash, XOnlyPublicKey, etc.)
► rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/test_utils/BUILD.bazel
    Replace bitcoin_0_28 with bitcoin_dogecoin
► rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/test_utils/Cargo.toml
    Switch to workspace bitcoin and secp256k1 0.29
► rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/test_utils/src/lib.rs
    Update verification function to use TapNodeHash and to_x_only_public_key
► rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/test_utils/src/lib.rs
    Update Message construction to from_digest_slice and schnorr verification usage
► rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/test_utils/BUILD.bazel
    Adjust dependency to bitcoin_dogecoin

@nmattia nmattia enabled auto-merge July 3, 2026 14:20
This bumps some crates and allows us to remove some duplication in the
lockfile.
@nmattia nmattia force-pushed the nm-secp-btc-bump branch from 4eac441 to ef54517 Compare July 9, 2026 09:01
@nmattia nmattia added this pull request to the merge queue Jul 9, 2026
Merged via the queue into master with commit 020422d Jul 9, 2026
63 of 64 checks passed
@nmattia nmattia deleted the nm-secp-btc-bump branch July 9, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants