Skip to content

Use request_meta middleware - #40

Merged
blind-oracle merged 4 commits into
mainfrom
igor/rework-middlewares
Aug 20, 2026
Merged

Use request_meta middleware#40
blind-oracle merged 4 commits into
mainfrom
igor/rework-middlewares

Conversation

@blind-oracle

Copy link
Copy Markdown
Contributor
  • Drops redundant request_id middleware
  • request_meta brings optional GeoIP support to HTTP LB
  • Adds CLI options to trust x-request-id/x-real-ip headers (won't be used on LB now)
  • Adds option to specify ACME account credentials (also not used for now)
  • Updates crates

@blind-oracle
blind-oracle requested a review from a team as a code owner August 19, 2026 12:41
@blind-oracle
blind-oracle requested a balanced review from Copilot August 19, 2026 12:41

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Replaces custom request-ID handling with request_meta, adding trusted-header, GeoIP, and ACME credential configuration.

Changes:

  • Integrates request metadata into routing and logging.
  • Adds related CLI options and ACME credential support.
  • Updates ic-bn-lib and transitive dependencies.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/tls.rs Supplies ACME account credentials.
src/routing.rs Installs request metadata middleware.
src/middleware/request_id.rs Removes redundant middleware.
src/middleware/mod.rs Removes deleted module export.
src/middleware/metrics.rs Logs remote address and country metadata.
src/core.rs Handles fallible router setup.
src/cli.rs Adds trust, GeoIP, and ACME options.
Cargo.toml Upgrades ic-bn-lib.
Cargo.lock Updates resolved dependencies.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/routing.rs
Comment thread src/cli.rs
@blind-oracle
blind-oracle merged commit 1899338 into main Aug 20, 2026
6 checks passed
@blind-oracle
blind-oracle deleted the igor/rework-middlewares branch August 20, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants