SwiftFormat - #2
Merged
Merged
Conversation
richardpiazza
commented
Mar 26, 2026
richardpiazza
marked this pull request as ready for review
March 26, 2026 16:24
Owner
|
Merging, thank you @richardpiazza |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a configuration and PR Job for SwfitFormat to keep code style and syntax in sync. Code can automatically be formatted to match expectations by (installing) and running
swiftformat .in the project directory. The GitHub action runners already have this tool installed.I've disabled a couple of rules to minimize the impact on the existing code. If there are any additional rules that should be disabled, I'd be happy to update. Here is the complete rule set: https://github.com/nicklockwood/SwiftFormat/blob/main/Rules.md
A couple of rules that I considered disabling which account for the biggest changes in the PR:
trailingSpace: By default this removes extra space characters at the end of lines and any line that is empty. I think this is best left enabled.trailingCommas: By default this adds trailing commas where supported which helps to minimize diffs when altering code. Again, another one that is good to keep enabled.Nikhil, feel free to completely reject this pull request if it's not something you are looking to incorporate on the project!