feature: add refused bequest smell detection - #72
Merged
Conversation
alxxjohn
added a commit
that referenced
this pull request
Jul 27, 2026
🤖 I have created a release *beep* *boop* --- ## [1.3.0](v1.2.2...v1.3.0) (2026-07-27) ### Features * add abstraction quality checks ([fc5a7ec](fc5a7ec)) * add change safety diff detectors ([ebc2f80](ebc2f80)) * add change safety PR summary metrics ([5b10ecd](5b10ecd)) * add delivery governance checks ([eb1b803](eb1b803)) * add local quality precision rules ([dd75b79](dd75b79)) * add local quality precision rules ([00c493e](00c493e)) * add observability and operations checks ([3e8713c](3e8713c)) * add operability, design, and delivery governance checks ([#70](#70)) ([a52199a](a52199a)) * add opt-in recommended check defaults ([1680b21](1680b21)) * add opt-in recommended check defaults ([#66](#66)) ([67510e3](67510e3)) * add production readiness rule families ([d58e8eb](d58e8eb)) * Add production reliability and data-readiness checks across languages ([#67](#67)) ([c243ead](c243ead)) * add refused bequest smell detection ([053cb1a](053cb1a)) * add refused bequest smell detection ([#72](#72)) ([4423aa4](4423aa4)) * add structural smell quality rules ([eefd8bd](eefd8bd)) * change safety testability refactors ([#69](#69)) ([9081ad3](9081ad3)) * deepen code smell and maintainability precision checks ([#71](#71)) ([d554347](d554347)) * deepen reliability parity checks ([fc8d769](fc8d769)) * expand production readiness language coverage ([588bf19](588bf19)) * scaffold change safety checks ([0b313d9](0b313d9)) ### Bug Fixes * dogfood production readiness coverage ([1110f4f](1110f4f)) * restore change testability detectors ([88f6df0](88f6df0)) * satisfy strict lint for change safety ([311716c](311716c)) * satisfy strict lint for operability governance ([abc9fd1](abc9fd1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This follow-up branch lands the deferred
smell.refused-bequestrule and pushes CodeGuard further toward change-quality review: not just “is this line bad?”, but “does this design shape make future changes harder, less safe, or harder to isolate?”The rule is deliberately conservative. It only emits when CodeGuard can see both inheritance/embedding evidence and multiple inherited-style methods being explicitly refused through no-op, unsupported, not-implemented, panic/throw/raise patterns.
What changed
Added
smell.refused-bequestsmell.refused-bequestAdded change-quality evidence metadata
Findings now include machine-readable evidence so reports can explain why the design shape is risky:
basesrefused_methodsrefused_countchange_signal=inheritance-contract-frictionThis makes the rule useful as PR-quality evidence, not just a lint warning.
Improved structural smell organization
quality_smells_refused_bequest.go.quality_smells.gounder CodeGuard’s own file/declaration dogfood limits.Metadata, docs, and fix guidance
smell.refused-bequest.docs/checks.mdanddocs/features.mdto list the shipped rule and frame structural smells as change-quality evidence.Validation
Ran:
Final CodeGuard dogfood:
Notes