fix: respect session verify attribute in ArtifactPath constructor - #508
Open
heyncth wants to merge 1 commit into
Open
fix: respect session verify attribute in ArtifactPath constructor#508heyncth wants to merge 1 commit into
heyncth wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
Fix Session 'verify' attribute being ignored when constructing ArtifactPath
Root Cause
When passing a
requests.Sessionwithverify=FalsetoArtifactPath(), the constructor ignores the session'sverifysetting and defaults toTrue(or the config file value). This happens in both__new__(Python <3.12) and__init__(Python >=3.12) methods.Solution
When a session is provided but
verifyis not explicitly passed as a keyword argument, inherit theverifyvalue from the session object instead of falling through to the hardcoded default. Explicitverifykwargs still take precedence over the session.Test Plan
Fixes #500