Reword the default cookie banner copy - #29
Open
dev-geddy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The seeded default led with the cost and gave no reason to accept, so almost nothing gets measured. Same facts, different order.
Before
After
Changes:
packages/db/migrations/0008_reword_cookie_banner.sql— custom migration. GuardedWHERE "cookieBannerText" = <the 0006 literal>, so an operator-edited banner is never clobbered (L2-ANALYTICS-08) and a re-run matches nothing. 0006 is left untouched — applied migrations are immutable; a fresh DB runs 0006 then 0008 and lands on the new copy.analytics-gate.tsx—FALLBACK_TEXTmirrors the new seed.docs/notes/analytics.md— the migration + why the copy reads the way it does.Copy-only; no behaviour change. Claims stay scoped to our use of the data — deliberately no promises about what Google does with it, since an operator can enable Signals/ads features and make them false. Layout untouched: Decline and Accept, one click each, same bar (EDPB wants reject equally easy, not identically styled).
Verified against a migrated local DB, and headless at 1440×900 (light + dark) and 390×780 with the config route stubbed: banner renders, zero
googletagmanagerrequests before Accept, one after, banner gone andgrantedpersisted, no console errors/warnings, no horizontal scroll. Typecheck + lint pass.Note this only lifts the accept rate — visitors who ignore the banner are still unmeasured. The coverage fix is a cookieless provider, proposed separately.