Added permanent additions and other prep for beta version - #14
Conversation
Propogate core update
|
Also, I figured out that the unittests thing can be ignored for now. |
deefdragon
left a comment
deefdragon
left a comment
There was a problem hiding this comment.
All of these are just comments asside from the one comment request for the de-prioritized comment.
| "Throne Room": { | ||
| ROOM_ITEM_ID_KEY: 802, | ||
| ROOM_ITEM_CLASSIFICATION_KEY: ItemClassification.progression | ItemClassification.useful, | ||
| ROOM_ITEM_CLASSIFICATION_KEY: ItemClassification.progression_deprioritized | ItemClassification.useful, |
There was a problem hiding this comment.
I assume this is because its so late game, but can you add a comment here as to why its de-prioritized?
There was a problem hiding this comment.
Its to try to prevent the randomizer from choosing throne room as the primary north lever access
| @@ -0,0 +1,68 @@ | |||
| Blue Room Notes | |||
There was a problem hiding this comment.
Just curious on how you are sorting these?
The lore only ones I can see being not that useful (IE Pump room's) but there are a few under useless that DO relate to game mechanics atleast.
Assuming most of these will end up as AP hints, etc. eventually? I don't think we were planning on putting the safe/gate codes anywhere crazy, right?
There was a problem hiding this comment.
I copied these from somewhere else, can't find the link rn.
Mostly just added them so I had a full list for knowledge sanity planning.
| entrance_hall.connect( | ||
| room, | ||
| "Entrance Hall Throne Room", | ||
| CanReachPickPosition("Throne Room") & CanReachLocation("Throne Room Floorplan", parent_region_name="Orindian Ruins"), # This is a lie to prevent the Throne Room from being placed early in logic, which was forcing the other routes much later in logic. |
There was a problem hiding this comment.
Should this be using the And func instead of &? I dont remember how far things got on using the rule builder logic.
There was a problem hiding this comment.
And/& are functionally identical iirc, its mostly just that And is more readable and allows filtering
|
fair re: the tests. Id recommend putting a test down for anything major or potentially fragile, but otherwise, they are largely to make sure core doesn't ship with a broken game. |
2 participants
No description provided.