Refactored to RuleBuilder - #13
Merged
Merged
Conversation
Propogate core update
Collaborator
Author
|
It seems to only happen when complex item logic is enabled, but room draft sanity is off |
Collaborator
Author
|
Figured out that TradingPostRule is causing recursion issues |
Collaborator
Author
|
Got it fixed by adding a cache to TradingPostRule to prevent repeat recursion |
deefdragon
requested changes
May 11, 2026
deefdragon
left a comment
deefdragon
left a comment
Owner
There was a problem hiding this comment.
Just a few code comprehensability things. (assuming the formatter doesn't interfere with them anyway)
Regarding the logic, given the other half of the code got merged when the PR got brought up to date, I don't think there's a good way for me to review it, but I assume most of the logic bugs will just have to be hunted down through testing at this point.
deefdragon
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got it mostly working, but complex, rare_complex, and extreme item logic seem to fail to place items.
@deefdragon if you could double check my logic to see why that might be happening, that would be great.