Nothing tells a contributor about the ratchets - #686
Merged
Conversation
onatozmenn
enabled auto-merge (squash)
July 30, 2026 22:39
onatozmenn
force-pushed
the
issue-645-document-the-ratchets
branch
from
July 30, 2026 23:30
4e483c5 to
4bbe13b
Compare
CONTRIBUTING.md gets a new section listing the ratchets that reject a reasonable-looking PR: the three that fire together when examples/ grows a file, the diagnostic-code-needs-a-test build failure, the shipped-module test-must-name-the-function rule, prose numbers checked against a real count, and the grammar test comparing the compiler's keywords against the editor's TextMate grammar in both directions. Each names the test file that enforces it. Also: nextest's --no-fail-fast default explained (cargo test hides failures past the first binary without it), and this machine's own build constraint (no MSVC linker, gnullvm target) written down as local rather than implied to be everyone's problem.
onatozmenn
force-pushed
the
issue-645-document-the-ratchets
branch
from
July 30, 2026 23:42
4bbe13b to
7fc22ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #645.
CONTRIBUTING.mdgets a new section listing the ratchets that reject a reasonable-looking PR: the three that fire together whenexamples/grows a file, the diagnostic-code-needs-a-test build failure, the shipped-module test-must-name-the-function rule, prose numbers checked against a real count, and the grammar test comparing the compiler's keywords against the editor's TextMate grammar in both directions. Each names the test file that enforces it.Also: nextest's
--no-fail-fastdefault explained (cargo testhides failures past the first binary without it), and this machine's own build constraint (no MSVC linker, gnullvm target) written down as local rather than implied to be everyone's problem.