Skip to content

fix(web): add aria-label to file-tab icon-only toolbar buttons - #5432

Merged
pedrofrxncx merged 1 commit into
mainfrom
fix/file-tab-icon-buttons-aria-label-w1
Jul 30, 2026
Merged

fix(web): add aria-label to file-tab icon-only toolbar buttons#5432
pedrofrxncx merged 1 commit into
mainfrom
fix/file-tab-icon-buttons-aria-label-w1

Conversation

@pedrofrxncx

@pedrofrxncx pedrofrxncx commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Source: bug found while sweeping apps/web/src for accessibility gaps in the main-panel-tabs directory.

Payoff: the three toolbar buttons in FileTab (download / open-in-new-tab / close) are icon-only with a Radix Tooltip but no aria-label. Radix's tooltip wiring only adds aria-describedby (a supplementary description), not an accessible name, so screen readers announce these as unlabeled "button" — same class of bug fixed in #4903, #5047, #5096, #5226, #5271, #5385, #5412. The sibling file code-tab.tsx already follows the correct aria-label pattern for its icon-only IDE-launch buttons, confirming file-tab.tsx was simply missed.

Fix: added aria-label={t(...)} to each of the three buttons, reusing the existing translation strings already used in the adjacent TooltipContent (mainPanelTabs.fileTab.download / .openInNewTab / .close) — no new i18n keys needed, no behavior change.

Verify: open a thread with a file output, tab into the file preview toolbar with a screen reader (or inspect the accessibility tree) and confirm each icon button now announces its action.

Checks run locally: bun run fmt (clean), bunx tsc --noEmit in apps/web (clean). No test file covers this component; full CI validates the rest.


Summary by cubic

Adds aria-labels to the three icon-only buttons in the FileTab toolbar so screen readers announce their actions; reuses existing i18n strings with no UI or behavior changes.

  • Bug Fixes
    • Added aria-labels to Download, Open in new tab, and Close buttons using existing mainPanelTabs.fileTab.* translations.
    • Resolves unlabeled “button” announcements; tooltips alone were not providing accessible names.

Written for commit 9eda91e. Summary will update on new commits.

Review in cubic

@pedrofrxncx
pedrofrxncx merged commit 637cfb6 into main Jul 30, 2026
22 checks passed
@pedrofrxncx
pedrofrxncx deleted the fix/file-tab-icon-buttons-aria-label-w1 branch July 30, 2026 15:58
decocms Bot pushed a commit that referenced this pull request Jul 30, 2026
PR: #5432 fix(web): add aria-label to file-tab icon-only toolbar buttons
Bump type: patch

- decocms (apps/api/package.json): 4.149.6 -> 4.149.7
- @decocms/native (apps/native/package.json): 4.149.6 -> 4.149.7

Deploy-Scope: web
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant