fix(web): add aria-label to file-tab icon-only toolbar buttons - #5432
Merged
Conversation
decocms Bot
pushed a commit
that referenced
this pull request
Jul 30, 2026
PR: #5432 fix(web): add aria-label to file-tab icon-only toolbar buttons Bump type: patch - decocms (apps/api/package.json): 4.149.6 -> 4.149.7 - @decocms/native (apps/native/package.json): 4.149.6 -> 4.149.7 Deploy-Scope: web
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source: bug found while sweeping
apps/web/srcfor accessibility gaps in the main-panel-tabs directory.Payoff: the three toolbar buttons in
FileTab(download / open-in-new-tab / close) are icon-only with a RadixTooltipbut noaria-label. Radix's tooltip wiring only addsaria-describedby(a supplementary description), not an accessible name, so screen readers announce these as unlabeled "button" — same class of bug fixed in #4903, #5047, #5096, #5226, #5271, #5385, #5412. The sibling filecode-tab.tsxalready follows the correctaria-labelpattern for its icon-only IDE-launch buttons, confirmingfile-tab.tsxwas simply missed.Fix: added
aria-label={t(...)}to each of the three buttons, reusing the existing translation strings already used in the adjacentTooltipContent(mainPanelTabs.fileTab.download/.openInNewTab/.close) — no new i18n keys needed, no behavior change.Verify: open a thread with a file output, tab into the file preview toolbar with a screen reader (or inspect the accessibility tree) and confirm each icon button now announces its action.
Checks run locally:
bun run fmt(clean),bunx tsc --noEmitinapps/web(clean). No test file covers this component; full CI validates the rest.Summary by cubic
Adds aria-labels to the three icon-only buttons in the FileTab toolbar so screen readers announce their actions; reuses existing i18n strings with no UI or behavior changes.
mainPanelTabs.fileTab.*translations.Written for commit 9eda91e. Summary will update on new commits.