fix(settings): translate hardcoded strings in org-connect page - #5382
Open
pedrofrxncx wants to merge 1 commit into
Open
fix(settings): translate hardcoded strings in org-connect page#5382pedrofrxncx wants to merge 1 commit into
pedrofrxncx wants to merge 1 commit into
Conversation
The org-connect settings view (Settings > Connections, connect-to-clients page) had zero i18n coverage — every label, button, tab, toast, and confirm dialog was a hardcoded English string, so pt-BR users saw untranslated UI throughout the whole page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source: i18n-coverage-audit focus area — the
apps/web/src/views/settings/org-connect.tsxview (Settings > Connections, the "connect to clients" page reached viaapps/web/src/routes/orgs/settings/connect.tsx) had zero i18n coverage: every JSX label, tab, button, toast, and confirm-dialog string was hardcoded English, so pt-BR users saw untranslated UI across the entire page.Payoff: this is a real, visible i18n gap for a page every org visits to connect Claude Code/Cursor/Codex/Claude Desktop clients — pt-BR users currently see raw English strings mixed in with the rest of a translated Settings section.
What changed:
settings.orgConnect.*key group (28 keys) toapps/web/src/i18n/en/settings.tsand its pt-BR mirror inapps/web/src/i18n/pt-br/settings.ts(thesatisfies Record<keyof typeof settingsEn, string>check keeps them in sync at compile time).org-connect.tsx(tab labels, descriptions, button text, toasts, the revoke confirm dialog, and the client-name list) witht(...)calls viauseT(). TheCLIENTSarray now carries alabelKey: TranslationKeyinstead of a rawlabel: string.{client},{error},{date},{name}), just routed through the i18n dictionary.How to verify: open Settings > Connections with the language preference set to Portuguese (
usePreferences()/ browser language) and confirm the whole page — tabs, descriptions, buttons, toasts — renders in Portuguese instead of a mix of English and Portuguese.Checks run locally:
bun run fmt(clean),cd apps/web && bunx tsc --noEmit(clean, confirms thesatisfies Record<...>mirror check passes and no consumer still references the oldlabelfield onCLIENTS). No existing test covers this file. Full CI (lint, full test suite) validates the rest.Summary by cubic
Translated all hardcoded strings on Settings > Connections (org-connect) to the i18n system. pt-BR users now see a fully localized page; no behavior changes.
settings.orgConnect.*keys to theenandpt-brdictionaries, kept in sync via a compile-time mirror check.apps/web/src/views/settings/org-connect.tsxwitht(...)viauseT().CLIENTSnow useslabelKeyfor localized labels.Written for commit 67e27af. Summary will update on new commits.