fix(cli): keep proxy listener alive in --proxy-only mode#2526
Open
fl64 wants to merge 1 commit into
Open
Conversation
--proxy-only printed the port and closed doneChan immediately, tearing down the listener before any VNC client could connect. Wait for ctx cancellation so the listener stays up for clients. Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
d8 v vnc --proxy-onlyprinted the port and exited immediately, so the VNC listener was gone before any viewer could connect. The proxy-only goroutine closeddoneChanright after printing the port, causingRunto return.Now it waits for the context to be canceled, so the listener stays up until the user interrupts the command.
Why do we need it, and what problem does it solve?
--proxy-onlywas unusable: users could not connect an external VNC viewer to the printed port because the proxy was already dead.What is the expected result?
d8 v vnc <vm> --proxy-only --port 5901prints{"port":5901}and stays running.127.0.0.1:5901reaches the VM.Checklist
Changelog entries