Organize lexicon search filters#542
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clearin a fixed heading above themPhi wordtophi wordInterface
The query scope now sits directly beneath the search box under
search in. The four narrowing controls belong to a labelledfilter bygroup. Their default options read simplyany, since the visible labels already identify what each selector controls.The grid uses explicit breakpoints rather than flex wrapping. Desktop columns remain equal and aligned; at 560 pixels and below, the controls form one full-width column. Long module and domain choices stay within their cells, and the complete page remains free of horizontal overflow at 320 pixels.
The
clearbutton stays at the upper right of the facet group. Keyboard focus uses the same visible gold outline as the paginator. Registered-compound searches continue to disable all four word-only facets, and their complete labelled controls now dim together.The separate Humanizer and voice pass removed the mechanical repetition between labels and default choices. For example,
semantic domainnow appears once as the label while its default choice is the plainany.Checks
python3 scripts/validate_examples.py --show-warnings(1,275 entries; 0 errors; 0 warnings)python3 scripts/test_vocabulary_schema.py(22 tests)python3 scripts/content_vocabulary_decisions.py --check(64 batches; 236 decisions)python3 scripts/test_content_vocabulary_decisions.py(8 tests)python3 scripts/test_name_forms.py(20 tests)python3 scripts/generate_reference.pypython3 scripts/build_site.pynode --check site/app.jsgit diff --check