Paginate the lexicon explorer#541
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
show morecontrol with numbered pagination above and below the lexicon resultsBehaviour
Each page contains up to 50 results. The status line gives the visible range and total, such as
showing 601-650 of 1,275 words, and distinguishes word, compound, and mixed result sets. Both pagers stay synchronized; they disappear when a result set fits on one page.Search text, search field, facets, and page number now have canonical URL parameters. Explicit page changes enter browser history, Back restores the earlier page and filters, and changing a live search or facet returns to page 1 without filling the history with every keystroke.
On narrow screens, the page window contracts to the first, current, and last pages with ellipses. The filter controls also respect the available width, preventing horizontal overflow at 320 pixels.
Page changes move keyboard focus to the refreshed result list. Current-page, previous-page, and next-page states have explicit accessible labels and semantics. The voice and Humanizer pass replaced the compressed noun-stack label
lexicon pages above resultswith the more naturalpages above the lexicon results, with the same correction below the list.Checks
node --check site/app.jspython3 scripts/validate_examples.py --show-warnings(1,275 entries; 0 errors; 0 warnings)python3 scripts/test_vocabulary_schema.py(22 tests)python3 scripts/content_vocabulary_decisions.py --check(64 batches; 236 decisions)python3 scripts/test_content_vocabulary_decisions.py(8 tests)python3 scripts/test_name_forms.py(20 tests)python3 scripts/generate_reference.pypython3 scripts/build_site.pygit diff --check