feat!: add dynamic cell and connection parameters for nest simulations. - #245
Draft
drodarie wants to merge 4 commits into
Draft
feat!: add dynamic cell and connection parameters for nest simulations.#245drodarie wants to merge 4 commits into
drodarie wants to merge 4 commits into
Conversation
move common resolution simulation class attribute to bsb-core abstract class rename nest_parameter type to nest_constant
Contributor
Author
|
@Helveg I implemented a first draft version of a refactor for the nest simulation that introduce dynamic simulation parameters. See #215 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## next #245 +/- ##
==========================================
- Coverage 82.81% 82.79% -0.02%
==========================================
Files 164 164
Lines 16778 16817 +39
Branches 1983 1992 +9
==========================================
+ Hits 13895 13924 +29
- Misses 2402 2409 +7
- Partials 481 484 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the work done
parametersattribute for NEST cell models and connection models. These are computed when the adapter is loading the simulationnest_parametertype tonest_constantto match naming convention.resolutionattribute from subclasses into the bsb-coreSimulationclassList which issues this resolves:
closes #215
Tasks
📚 Documentation preview 📚: https://bsb-neuron--245.org.readthedocs.build/en/245/
📚 Documentation preview 📚: https://bsb-nest--245.org.readthedocs.build/en/245/
📚 Documentation preview 📚: https://bsb-core--245.org.readthedocs.build/en/245/
📚 Documentation preview 📚: https://bsb-arbor--245.org.readthedocs.build/en/245/
📚 Documentation preview 📚: https://nrn-patch--245.org.readthedocs.build/en/245/
📚 Documentation preview 📚: https://bsb-hdf5--245.org.readthedocs.build/en/245/
📚 Documentation preview 📚: https://bsb-otel--245.org.readthedocs.build/en/245/
📚 Documentation preview 📚: https://arborize--245.org.readthedocs.build/en/245/