Skip to content

feat!: add dynamic cell and connection parameters for nest simulations. - #245

Draft
drodarie wants to merge 4 commits into
nextfrom
feature/nest_parameters
Draft

feat!: add dynamic cell and connection parameters for nest simulations.#245
drodarie wants to merge 4 commits into
nextfrom
feature/nest_parameters

Conversation

@drodarie

@drodarie drodarie commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Describe the work done

  • Add parameters attribute for NEST cell models and connection models. These are computed when the adapter is loading the simulation
  • Rename nest_parameter type to nest_constant to match naming convention.
  • Move common resolution attribute from subclasses into the bsb-core Simulation class

List which issues this resolves:

closes #215

Tasks

  • Added tests
  • Updated documentation

📚 Documentation preview 📚: https://bsb-neuron--245.org.readthedocs.build/en/245/


📚 Documentation preview 📚: https://bsb-nest--245.org.readthedocs.build/en/245/


📚 Documentation preview 📚: https://bsb-core--245.org.readthedocs.build/en/245/


📚 Documentation preview 📚: https://bsb-arbor--245.org.readthedocs.build/en/245/


📚 Documentation preview 📚: https://nrn-patch--245.org.readthedocs.build/en/245/


📚 Documentation preview 📚: https://bsb-hdf5--245.org.readthedocs.build/en/245/


📚 Documentation preview 📚: https://bsb-otel--245.org.readthedocs.build/en/245/


📚 Documentation preview 📚: https://arborize--245.org.readthedocs.build/en/245/

move common resolution simulation class attribute to bsb-core abstract class
rename nest_parameter type to nest_constant
@drodarie

drodarie commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

@Helveg I implemented a first draft version of a refactor for the nest simulation that introduce dynamic simulation parameters. See #215
Can I have your feedback on it? I am not sure if my implementation is correct.
Also I am not sure of what to do with the old class Parameter of bsb-core that seems to be used only in bsb-neuron...

@drodarie
drodarie changed the base branch from main to next June 10, 2026 13:16
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.15942% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.79%. Comparing base (06cab36) to head (d06f7f9).

Files with missing lines Patch % Lines
packages/bsb-nest/bsb_nest/connection.py 75.75% 4 Missing and 4 partials ⚠️
packages/bsb-core/bsb/simulation/parameter.py 83.33% 3 Missing ⚠️
packages/bsb-nest/bsb_nest/cell.py 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #245      +/-   ##
==========================================
- Coverage   82.81%   82.79%   -0.02%     
==========================================
  Files         164      164              
  Lines       16778    16817      +39     
  Branches     1983     1992       +9     
==========================================
+ Hits        13895    13924      +29     
- Misses       2402     2409       +7     
- Partials      481      484       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NEST synapses with distance-based delays

1 participant