fix: Header main navigation hover/active background for multiline items#1302
Open
AliMahmoudDev wants to merge 1 commit into
Open
fix: Header main navigation hover/active background for multiline items#1302AliMahmoudDev wants to merge 1 commit into
AliMahmoudDev wants to merge 1 commit into
Conversation
Change fixed height to min-height for navigation links so that when a nav item text wraps to multiple lines, the hover/active background grows to cover all lines instead of only the first. Fixes db-ui#1298
AliMahmoudDev
requested review from
annsch,
bruno-sch,
dkolba,
mfranzke and
nmerget
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the header main navigation hover/active background not covering multiline nav items (#1298).
Problem
When a navigation item wraps to two lines (e.g., on smaller viewports or with longer labels), the hover/active background only covers the first line. The second line remains without a background color.
This is caused by a fixed
height: 2.5remon the navigation link element, which prevents the element from growing to accommodate wrapped text.Fix
Changed
height: 2.5remtomin-height: 2.5remin the main navigation link styles. This allows the element to grow beyond 2.5rem when the text wraps to multiple lines, ensuring the hover/active background covers all lines.Fixes #1298