Fix LineFloat to store coordinates as float instead of double (#89) - #289
Open
pangwangshu wants to merge 2 commits into
Open
Fix LineFloat to store coordinates as float instead of double (#89)#289pangwangshu wants to merge 2 commits into
pangwangshu wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LineFloatwas declaring itsx1,y1,x2,y2fields (and constructor/factory parameters) asdoubleinstead offloat, defeating the purpose of having a separate float-precisionLineimplementation alongsideLineDouble.Fixes #89
Changes
LineFloat's fields, private constructor, andcreate()factory method to usefloatinstead ofdoublefor coordinates (LineFloat.java)LineFloatfields are declared asfloatwhileLineDoublefields remaindouble(via reflection)Geometries.line(...)created from float coordinates reportsisDoublePrecision() == false, and from double coordinates reportstrueTest plan
mvn testpasses, including newLineTestcases