Close connection on heartbeat OperationTimedOutException, not just SocketException#631
Open
fakefeik wants to merge 1 commit into
Open
Close connection on heartbeat OperationTimedOutException, not just SocketException#631fakefeik wants to merge 1 commit into
fakefeik wants to merge 1 commit into
Conversation
…cketException A heartbeat (OptionsRequest) that times out because the peer stopped responding while the TCP connection stays established was previously ignored, since IdleTimeoutHandler only closed the connection for SocketException. This left connections to a dead-but-still-accepting host open indefinitely once application traffic stopped flowing on them, well past the point the host was already marked DOWN via other connections. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Collaborator
|
Hi, thanks for the PR! Posting this here just to acknowledge that I'm aware of it but I don't have the cycles to look at it right now and there's no plans for the next release yet. Also, we're unable to accept external contributions right now due to our old CLA process going away so we're still trying to get that resolved too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A heartbeat (OptionsRequest) that times out because the peer stopped responding while the TCP connection stays established was previously ignored, since IdleTimeoutHandler only closed the connection for SocketException. This left connections to a dead-but-still-accepting host open indefinitely once application traffic stopped flowing on them, well past the point the host was already marked DOWN via other connections.
Closes #630