faults: Add F2421 RTC battery validation - #412
Open
monrog2 wants to merge 1 commit into
Open
Conversation
Block upgrades when an active F2421 reports the exact RTC battery voltage low reason, while ignoring stale and unrelated fault instances. Include issue-derived coverage and validation guidance. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
monrog2
commented
Jul 24, 2026
monrog2
left a comment
Collaborator
Author
There was a problem hiding this comment.
Blocking feedback: the RTC battery fault is detected correctly, but its result category understates the documented operational impact. GitHub does not allow the PR author to submit a Request changes review on their own PR.
|
|
||
| @check_wrapper(check_title="Switch RTC Battery Voltage (F2421 equipment-diags-failed)") | ||
| def rtc_battery_voltage_low_check(**kwargs): | ||
| result = FAIL_UF |
Collaborator
Author
There was a problem hiding this comment.
Blocking: Please classify this as FAIL_O rather than FAIL_UF and update the active/malformed-fault test expectations accordingly. Issue #351 and the new validation documentation state that a low RTC battery can reset the switch clock during an upgrade or power cycle, causing certificate validation to fail and preventing the switch from rejoining the fabric. That is an outage risk, so FAIL - OUTAGE WARNING!! is the appropriate result category.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The RTC battery voltage is lowreasonfaultInstquery by both fault code and RTC-low description, then enforce exact reason matching client-sideValidation
python3 -m py_compile aci-preupgrade-validation-script.py tests/checks/rtc_battery_voltage_low_check/test_rtc_battery_voltage_low_check.pygit diff --checkCloses #351