Skip to content

faults: Add F2421 RTC battery validation - #412

Open
monrog2 wants to merge 1 commit into
v4.2.0-devfrom
issue-351-rtc-battery-fault
Open

faults: Add F2421 RTC battery validation#412
monrog2 wants to merge 1 commit into
v4.2.0-devfrom
issue-351-rtc-battery-fault

Conversation

@monrog2

@monrog2 monrog2 commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add an upgrade-blocking check for active F2421 faults reporting the exact The RTC battery voltage is low reason
  • scope the APIC faultInst query by both fault code and RTC-low description, then enforce exact reason matching client-side
  • report affected pod, node, supervisor, severity, and lifecycle while preserving malformed active rows
  • document remediation and add issue-derived coverage for active, stale, unrelated-reason, empty, and malformed responses

Validation

  • python3 -m py_compile aci-preupgrade-validation-script.py tests/checks/rtc_battery_voltage_low_check/test_rtc_battery_voltage_low_check.py
  • git diff --check
  • focused tests: 5 passed
  • full suite: 921 passed

Closes #351

Block upgrades when an active F2421 reports the exact RTC battery voltage low reason, while ignoring stale and unrelated fault instances. Include issue-derived coverage and validation guidance.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@monrog2 monrog2 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking feedback: the RTC battery fault is detected correctly, but its result category understates the documented operational impact. GitHub does not allow the PR author to submit a Request changes review on their own PR.


@check_wrapper(check_title="Switch RTC Battery Voltage (F2421 equipment-diags-failed)")
def rtc_battery_voltage_low_check(**kwargs):
result = FAIL_UF

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: Please classify this as FAIL_O rather than FAIL_UF and update the active/malformed-fault test expectations accordingly. Issue #351 and the new validation documentation state that a low RTC battery can reset the switch clock during an upgrade or power cycle, causing certificate validation to fail and preventing the switch from rejoining the fabric. That is an outage risk, so FAIL - OUTAGE WARNING!! is the appropriate result category.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant