Skip to content

checks: accept supported CIMC 4.2(3e) on APIC 6.1(5) - #411

Open
monrog2 wants to merge 1 commit into
v4.2.0-devfrom
issue-338-cimc-615-supported-version
Open

checks: accept supported CIMC 4.2(3e) on APIC 6.1(5)#411
monrog2 wants to merge 1 commit into
v4.2.0-devfrom
issue-338-cimc-615-supported-version

Conversation

@monrog2

@monrog2 monrog2 commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • accept CIMC 4.2(3e) for APIC 6.1(5) on M5 (APIC-L3/M3) and M6 (APIC-L4/M4) controllers, as explicitly supported by the target release notes
  • preserve catalog-based upgrade failures for other CIMC versions
  • preserve the CSCwo74485 upgrade-ordering failure on affected M4/L4 paths
  • document the release-note exception and add regression fixtures for supported and unsupported combinations

Why

The APIC image catalog can recommend a newer CIMC release than the versions explicitly supported by the APIC release notes. The check treated the catalog recommendation as a hard minimum and incorrectly returned FAIL - UPGRADE FAILURE for the supported 4.2(3e) / 6.1(5e) combination reported in #338.

Validation

  • focused CIMC compatibility suite: 11 passed
  • full suite: 919 passed
  • Python compile check passed
  • git diff --check passed

Fixes #338

Honor the APIC 6.1(5) release-note support exception for M5/M6 controllers while preserving the CSCwo74485 ordering gate and catalog failures for other versions.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@monrog2 monrog2 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking review finding: the release-note compatibility override is incomplete and still rejects supported APIC-L4/M4 CIMC versions. GitHub does not permit authors to formally request changes on their own pull requests.

release_note_supported = (
tversion.simple_version == "6.1(5)"
and model in ("apicl3", "apicm3", "apicl4", "apicm4")
and current_cimc == "4.2(3e)"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: This exact-match exception implements the APIC 6.1(5) release-note table incompletely. For APIC-L4/M4, the same release notes also support CIMC 4.3(2.230207) and 4.3(2.240009). Both remain below the catalog recommendation 4.3(4.252002), so this condition stays false and the check incorrectly returns FAIL_UF for supported upgrades. Please use a model-specific allowlist covering all release-note-supported versions below the catalog recommendation, retain the preceding CSCwo74485 ordering gate, update the documentation, and add PASS tests for both omitted M6 versions plus an unlisted-version failure test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant