checks: report APIC database collection errors - #410
Open
monrog2 wants to merge 2 commits into
Open
Conversation
Report missing, empty, unavailable, or malformed mitmocounters data as an explicit error instead of passing incomplete collection. Preserve any oversized-class findings and add regression coverage for sorting and threshold behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
Live validation findings on APIC 6.0(8e):
I am updating this PR to retry each legacy counter read a bounded number of times, capture the final command error instead of discarding stderr, and retain ERROR behavior when all attempts fail. |
Retry each legacy mitmocounters read up to three times and capture the final command error when collection remains unavailable. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
Integration validation update:
This validates the successful collection path in the live environment. Unit coverage separately verifies fail-once/succeed-on-retry and persistent-failure behavior. The overall integration job remains red for unrelated existing fabric/check failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apic_database_size_checkfrom reporting PASS when legacymitmocountersfiles are missing, empty, unavailable, or malformed/debugpopulationWhy
On affected pre-6.1(3a) releases, a missing
mitmocounters/mofile causedcatto fail while the finalsortprocess returned success. The check then received no rows and incorrectly reported PASS. Live 6.0(8e) testing also showed that the dynamic/debugfiles can be transiently unavailable even though they are subsequently readable by the sametechsupportuser.Validation
The overall integration job remains red due to unrelated existing fabric/check failures.
Fixes #327