checks: Expand out-of-service detection to fabric ports - #409
Conversation
Use explicit usage-mask equality filters to cover access and fabric blacklist states without matching unrelated mask values. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Integration test resultsTested commit
The integration job exited nonzero because of unrelated baseline and lab issues. The primary script error was No integration failure was attributable to this PR. |
monrog2
left a comment
There was a problem hiding this comment.
No findings.
Reviewed the complete v4.2.0-dev...152b77f diff for APIC query correctness and scale, validation semantics and registration, Python 2.7/3.8 compatibility, documentation, and regression coverage. The explicit usage-mask filter matches issue #292 (32, 34, 36, and 292) without widening to unrelated masks, and remains a single server-side class query.
Validation evidence:
- GitHub Python 2.7 and 3.8 checks passed
- Targeted regression suite: 12/12 passed
- Full regression suite: 926/926 passed
- TGZ integration:
out_of_service_ports_checkpassed on all 15 collected fabrics
The integration job failures were confirmed unrelated to this PR and present in the base or lab environment. This change is ready from a code-review perspective.
Submitted as a comment review because GitHub does not allow the PR author to approve their own PR.
Summary
32,34,36, and292Validation
git diff --check origin/v4.2.0-dev...HEADpassedFixes #292