[FFI] Complete Arrow shutdown before free returns - #736
Open
nikolaobradovic-db wants to merge 2 commits into
Open
[FFI] Complete Arrow shutdown before free returns#736nikolaobradovic-db wants to merge 2 commits into
nikolaobradovic-db wants to merge 2 commits into
Conversation
nikolaobradovic-db
requested review from
elenagaljak-db and
teodordelibasic-db
August 14, 2026 14:51
nikolaobradovic-db
force-pushed
the
nikola-obradovic_data/zerobus/ffi_use_after_free_fix
branch
from
August 18, 2026 08:16
42b4240 to
d5e950f
Compare
| { | ||
| tokio::task::block_in_place(|| abort_and_drop_arrow_stream(stream)); | ||
| } | ||
| Ok(_) => abort_and_drop_arrow_stream_on_thread(stream), |
Collaborator
There was a problem hiding this comment.
This blocking branch can deadlock for a direct FFI consumer calling free from a single-thread Tokio runtime when a C Data release callback waits for work on that same runtime. I reproduced this locally. Our wrappers call free, but they use IPC ingestion only, so they take the earlier nonblocking path.
Just flagging this, myb its okay to leave it as is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
How is this tested?